From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Kenichi Handa <handa@gnu.org>
Cc: 15138-done@debbugs.gnu.org, darren.hoo@gmail.com
Subject: bug#15138: revno: 114089 change causes cjk characters not shown correctly
Date: Thu, 5 Sep 2013 18:34:19 +0200 [thread overview]
Message-ID: <7F96315D-1DED-4D34-BA84-73BC9BAF0E77@swipnet.se> (raw)
In-Reply-To: <87hadzidj0.fsf@gnu.org>
Hello.
5 sep 2013 kl. 15:49 skrev Kenichi Handa <handa@gnu.org>:
> In article <7FEF1248-81A6-4E06-8F08-29A02CE72E00@swipnet.se>, Jan Djärv <jan.h.d@swipnet.se> writes:
>
>> Good, closing.
>
> I have another question about this change.
>
> /* Fonts often have characters in other scripts, like symbol, even if they
> don't match script: symbol. So check if the character is present
> in the current face first. Only enable for NS for now, but should
> perhaps be general? */
> Lisp_Object font_object;
> XSETFONT (font_object, face->font);
> if (font_has_char (f, font_object, c)) return face->id;
>
> With it, face->font may vary depending on the preceding
> character. So if you have these lines:
> abc•
> あいう•
> the two "•"s will be displayed by different fonts. Isn't it
> better to try the font selected for ASCII as this:
>
> XSETFONT (font_object, face->ascii_face->font);
I don't know, I never had that situation. I guess if the goal is to show same glyphs, ascii_face->font is a better choice. But if it is to have a consistent look with the surrounding text, it it not.
Consider a buffer where only あいう• is entered. I would assume the current font would be a better choice in this case.
Jan D.
next prev parent reply other threads:[~2013-09-05 16:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 2:37 bug#15138: Font rendering error on OSX Michael Toomim
2013-08-20 2:44 ` Michael Toomim
2013-08-26 16:14 ` Jan Djärv
2013-08-27 15:59 ` bug#15138: Font selection " Jan Djärv
2013-08-27 19:08 ` Michael Toomim
2013-08-28 4:55 ` Jan Djärv
2013-09-01 10:00 ` Jan Djärv
2013-09-01 18:51 ` Michael Toomim
2013-09-02 14:50 ` Kenichi Handa
2013-09-02 15:57 ` Jan Djärv
2013-09-03 12:10 ` Kenichi Handa
2013-09-03 15:26 ` Jan Djärv
2013-09-05 12:57 ` Kenichi Handa
2013-09-05 16:56 ` Jan Djärv
2013-09-02 18:34 ` Michael Toomim
2013-09-02 19:13 ` Jan Djärv
2013-09-02 17:29 ` bug#15138: revno: 114089 change causes cjk characters not shown correctly Darren Hoo
2013-09-03 7:00 ` Jan Djärv
2013-09-03 14:37 ` Darren Hoo
2013-09-03 15:18 ` Jan Djärv
2013-09-05 13:49 ` Kenichi Handa
2013-09-05 16:34 ` Jan Djärv [this message]
2013-09-05 17:04 ` Stefan Monnier
2013-09-05 17:25 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F96315D-1DED-4D34-BA84-73BC9BAF0E77@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=15138-done@debbugs.gnu.org \
--cc=darren.hoo@gmail.com \
--cc=handa@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.