From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: 9919@debbugs.gnu.org
Subject: bug#9919: 24.0.91; font-lock broken in dired
Date: Mon, 9 Jan 2012 10:59:58 -0800 [thread overview]
Message-ID: <7F9343C4FA564C29BE7E8576E5A25183@us.oracle.com> (raw)
In-Reply-To: <jwvzkdwddv9.fsf-monnier+emacs@gnu.org>
> > I am still getting reports about this wrt dired+.el from users on
> > GNU/Linux. So perhaps my workaround is not sufficient there - dunno.
>
> Whenever you change font-lock-defaults, you need to cause
> font-lock-keywords (and the text already font-locked) to be refreshed,
> unless you know for sure that font-lock-mode has not yet been started.
Your "whenever" obviously does not apply to Emacs 20-22, since
`font-lock-refresh-defaults' does not even exist in those releases.
And at least for my code, "whenever" is true only for Emacs 24, not Emacs 23
(which also has `font-lock-refresh-defaults'). And the problem did not exist in
Emacs 24 either, until the build where I reported the bug.
I have this code, which has always worked and still works with Emacs 20 through
23.3:
(add-hook
'dired-mode-hook
(lambda ()
(set (make-local-variable 'font-lock-defaults)
(cons '(dired-font-lock-keywords diredp-font-lock-keywords-1)
(cdr font-lock-defaults)))
;; Emacs 24+: Need to refresh `font-lock-keywords' from
`font-lock-defaults'.
(when (fboundp 'font-lock-refresh-defaults) (font-lock-refresh-defaults))))
The last bit, which invokes `font-lock-refresh-defaults', I had to add for Emacs
24.
Similarly, for buff-menu+.el, I need to do likewise on `buffer-menu-mode-hook'.
Again, this workaround is needed only for Emacs 24.
> > In any case, this is a regression and a performance problem.
>
> I don't see any evidence of a performance problem.
This means, in effect, that fontification must now be done twice, or else it is
incorrect. That's the performance hit I meant: font-locking twice. What has
always given correct fontification before with a single fontification (and still
does, in the published Emacs releases) now does not, I must re-fontify
completely.
Am I missing something here? Is there a way to get what's needed without
fontifying twice? That's expensive. What's the cause of this
change/regression? Thx.
next prev parent reply other threads:[~2012-01-09 18:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 15:11 bug#9919: 24.0.91; font-lock broken in dired Drew Adams
2011-10-31 22:06 ` Drew Adams
2011-10-31 22:29 ` Drew Adams
2011-11-05 1:34 ` Christoph Scholtes
2011-11-05 15:30 ` Drew Adams
2012-01-09 15:52 ` Drew Adams
2012-01-09 17:04 ` Stefan Monnier
2012-01-09 18:59 ` Drew Adams [this message]
2012-01-09 22:36 ` Stefan Monnier
2012-01-10 0:04 ` Drew Adams
2012-01-10 1:26 ` Stefan Monnier
2012-01-10 1:35 ` Drew Adams
2012-01-10 3:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F9343C4FA564C29BE7E8576E5A25183@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=9919@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.