From: "Mattias Engdegård" <mattiase@acm.org>
To: Narendra Joshi <narendraj9@gmail.com>
Cc: 40185-done@debbugs.gnu.org
Subject: bug#40185: #40185: 28.0.50; Emacs Calc selection of a sub-formula doesn't highlight it
Date: Mon, 23 Mar 2020 21:37:40 +0100 [thread overview]
Message-ID: <7F26B461-ABA9-4E84-9DB0-6F9B6832EA28@acm.org> (raw)
In-Reply-To: <875zeuhovo.fsf@gmail.com>
23 mars 2020 kl. 20.06 skrev Narendra Joshi <narendraj9@gmail.com>:
> Can you please help me
> understand what exactly the issue was and how declaring the variable
> fixed it? I see that it is `defvar`ed in `calc-ext.el`.
'defvar' without an initial value is a declaration scoped to the surrounding lexical scope (or file, if at top level). It appears that calc.el does not require calc-ext, so that math-comp-selected was assumed to be lexical where it was bound in math-format-stack-value. This caused it to have the wrong number further down the call tree (in math-comp-to-string-flat, I think).
In Emacs 26 and earlier, calc.el used dynamic binding.
Thanks for verifying! Patch pushed to emacs-27.
next prev parent reply other threads:[~2020-03-23 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 18:24 bug#40185: 28.0.50; Emacs Calc selection of a sub-formula doesn't highlight it Narendra Joshi
2020-03-23 17:43 ` bug#40185: #40185: " Mattias Engdegård
2020-03-23 19:06 ` Narendra Joshi
2020-03-23 20:37 ` Mattias Engdegård [this message]
2020-03-23 22:37 ` Narendra Joshi
2020-03-24 9:07 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F26B461-ABA9-4E84-9DB0-6F9B6832EA28@acm.org \
--to=mattiase@acm.org \
--cc=40185-done@debbugs.gnu.org \
--cc=narendraj9@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.