From: "Drew Adams" <drew.adams@oracle.com>
To: "'Dan Nicolaescu'" <dann@ics.uci.edu>, "'Jason Rumney'" <jasonr@gnu.org>
Cc: 'Chong Yidong' <cyd@stupidchicken.com>,
rms@gnu.org, 3370@emacsbugs.donarmstrong.com
Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately
Date: Mon, 25 May 2009 00:02:02 -0700 [thread overview]
Message-ID: <7E9473EA45C34C5EBECFBD78AB625B5E@us.oracle.com> (raw)
In-Reply-To: <200905250526.n4P5Q4sl024737@godzilla.ics.uci.edu>
> 'indent was also the preference of the person that wrote the new
> incarnation of the region indent code and who explicitly approved the
> change: Stefan.
`comment-region' is not, or at least was not, about indenting. It is about
commenting out the code in the region.
There is nothing in the Elisp manual about `comment-region'. What there is about
it in the Emacs manual does not mention at all how it affects indenting or is
affected by indenting, and it does not mention `comment-style' at all.
The only mention of indenting in a node that talks also about `comment-region'
is the mention that lines with multiple comment delimiters can sometimes be
indented differently, depending on the number of comment delimiters. That has
always been the case in Emacs (;;; vs ;; vs ; - indented differently by TAB or
C-M-q etc.). Previously, there was no relation between `comment-region' and
indenting, AFAIK. And there is still no documented relation, that I can find.
Finally, the doc string for `comment-region' still says exactly what it said for
Emacs 22. And it says that it comments (or uncomments) "each line" in the
region. Not just some text in the line, starting after some whitespace, but the
(whole) line. And it says nothing about indenting the commented line.
And it says, "By default, comments start at the left margin". Admittedly, that
is vague and could be interpreted to mean different things. But there is
definitely no mention that `comment-region' indents lines that it comments, that
is, that it produces an indented comment.
next prev parent reply other threads:[~2009-05-25 7:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 23:31 bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Chong Yidong
2009-05-24 23:57 ` Drew Adams
2009-05-25 0:04 ` Lennart Borgman
2009-05-25 0:54 ` Chong Yidong
2009-05-25 1:28 ` Jason Rumney
2009-05-25 2:09 ` Drew Adams
2009-05-25 4:47 ` Chong Yidong
2009-05-25 7:01 ` Drew Adams
2009-05-25 13:27 ` Chong Yidong
2009-05-25 17:42 ` Drew Adams
2009-05-25 13:38 ` Stefan Monnier
2009-05-25 17:42 ` Drew Adams
2009-05-25 21:22 ` Stefan Monnier
2009-05-25 21:56 ` Drew Adams
2009-05-25 22:46 ` Jason Rumney
2009-05-26 1:16 ` Stefan Monnier
2012-02-22 2:46 ` Glenn Morris
2009-05-25 5:26 ` Dan Nicolaescu
2009-05-25 7:02 ` Drew Adams [this message]
2009-05-25 13:30 ` Chong Yidong
2009-05-25 13:39 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2009-05-24 22:31 Drew Adams
2009-05-25 13:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7E9473EA45C34C5EBECFBD78AB625B5E@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=3370@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
--cc=dann@ics.uci.edu \
--cc=jasonr@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.