From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#8856: 24.0.50; regression: special-display-frame is no longer dedicated Date: Sun, 26 Jun 2011 07:56:33 -0700 Message-ID: <7E36258F1C874F1199F2630002DC4915@us.oracle.com> References: <853BDEF1AA9646ACB90724066E1A5951@us.oracle.com><4DFB6BBF.3080504@gmx.at><6FAF5DFD0E094823A512C3E0E87B6DF5@us.oracle.com><4DFE09A7.10500@gmx.at><0137606B527A48C69E3D6C704C5C6595@us.oracle.com><4DFF1709.3010409@gmx.at><309F7428711D4BEBB6063C60808D8069@us.oracle.com><4E00C54C.5080108@gmx.at><7AF0B637CAE14034973FBCC658AFEBD9@us.oracle.com><31769215C0FF4E1E89F9F641C5843E91@us.oracle.com><4E033CBA.1050700@gmx.at><4E037708.2000205@gmx.at><4E045081.3020009@gmx.at><90A40DD7F1B14BC1BE282ADB68D57511@us.oracle.com><4E05ED7B.2070307@gmx.at> <4023AF2C90A24208ABCC1644CB15F776@us.oracle.com> <8A3D5626004B4945A624B69463A0B849@us.oracle.com> <4E06056! E.8030907@gmx.at> <4! E06141D.80302@gmx.at> ! <4E07390B.7030702@gmx .at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1309100243 13592 80.91.229.12 (26 Jun 2011 14:57:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 26 Jun 2011 14:57:23 +0000 (UTC) Cc: 8856@debbugs.gnu.org To: "'martin rudalics'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 26 16:57:19 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qaqly-0003hg-MH for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jun 2011 16:57:18 +0200 Original-Received: from localhost ([::1]:56871 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qaqly-0003km-1X for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jun 2011 10:57:18 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:60053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qaqlk-0003kc-Os for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2011 10:57:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qaqlj-0000l0-FP for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2011 10:57:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qaqlj-0000kw-CW for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2011 10:57:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Qaqli-0004qB-Cz; Sun, 26 Jun 2011 10:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2011 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8856-submit@debbugs.gnu.org id=B8856.130910021818598 (code B ref 8856); Sun, 26 Jun 2011 14:57:02 +0000 Original-Received: (at 8856) by debbugs.gnu.org; 26 Jun 2011 14:56:58 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qaqle-0004pv-CM for submit@debbugs.gnu.org; Sun, 26 Jun 2011 10:56:58 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qaqlc-0004pi-8J for 8856@debbugs.gnu.org; Sun, 26 Jun 2011 10:56:56 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet10.oracle.com (Switch-3.4.4/Switch-3.4.2) with ESMTP id p5QEulIj023898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 26 Jun 2011 14:56:49 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p5QEulBR022847 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 26 Jun 2011 14:56:47 GMT Original-Received: from abhmt002.oracle.com (abhmt002.oracle.com [141.146.116.11]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p5QEugYJ015685; Sun, 26 Jun 2011 09:56:42 -0500 Original-Received: from dradamslap1 (/10.159.51.223) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 26 Jun 2011 07:56:41 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4E07390B.7030702@gmx.at> Thread-Index: Acw0B/sn6ImPw3fzTG2zAyDzM98VCwABkG5g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.4E0748B2.000A:SCFMA922111,ss=1,re=-4.000,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 26 Jun 2011 10:57:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47504 Archived-At: > I see it now. The Completions buffer pop ups up in a normal > frame instead. I attached a fixed copy of window.el, please try it. > Completing now deletes the Completions frame. I also restored the > old meaning of the third argument of `display-buffer' for the > described frame values. Bravo! And thank you. Completions is now correctly redirected: no more read-only error. However, I now see this problem, which might or might not be due to this fix - dunno. It seems that the *Completions* window is still not a proper dedicated window, at least some of the time (?). `C-g' and `C-]' in Icicles during completion invoke `icicle-abort-recursive-edit' (in file icicles-mcmd.el), which does this: (if (not (active-minibuffer-window)) (when (get-buffer "*Completions*") (kill-buffer (get-buffer "*Completions*"))) (icicle-remove-Completions-window 'FORCE)) (abort-recursive-edit) This should remove the *Completions* window/frame. In the case in question, the second branch of the `if' is taken, invoking `icicle-remove-Completions-window' (which is also in file icicles-mcmd.el). What is happening now is that the first `C-g' does not remove Completions (e.g. delete the frame) - a second `C-g' is needed. Similarly, if you do `C-x 0' in the minibuffer it should remove Completions (it is bound to `icicle-remove-Completions-window'). That also does not work (no matter how many times you use it in a row). Here is what is happening, by `M-x debug-on-entry icicle-abort-recursive-edit'. Debugger entered--returning value: nil window-dedicated-p(#) * (if (window-dedicated-p (get-buffer-window "*Completions*" (quote visible))) (progn (condition-case nil (icicle-delete-windows-on "*Completions*") (error nil)))) * (when (window-dedicated-p (get-buffer-window "*Completions*" (quote visible))) (condition-case nil (icicle-delete-windows-on "*Completions*") (error nil))) * (cond ((and (get-buffer-window "*Completions*") (or force (and (window-live-p swin) (not (eq (window-buffer swin) (get-buffer "*Completions*")))) (interactive-p))) (condition-case nil (delete-window (get-buffer-window "*Completions*")) (error nil)) (bury-buffer (get-buffer "*Completions*"))) ((and (get-buffer-window "*Completions*" (quote visible)) (or force (and (window-live-p swin) (not (eq (window-buffer swin) (get-buffer "*Completions*")))) (interactive-p))) (when (window-dedicated-p (get-buffer-window "*Completions*" (quote visible))) (condition-case nil (icicle-delete-windows-on "*Completions*") (error nil))) (bury-buffer (get-buffer "*Completions*")))) * (let ((swin (selected-window))) (when (and (window-minibuffer-p swin) (fboundp (quote minibuffer-selected-window))) (setq swin (minibuffer-selected-window))) (cond ((and (get-buffer-window "*Completions*") (or force (and (window-live-p swin) (not (eq ... ...))) (interactive-p))) (condition-case nil (delete-window (get-buffer-window "*Completions*")) (error nil)) (bury-buffer (get-buffer "*Completions*"))) ((and (get-buffer-window "*Completions*" (quote visible)) (or force (and (window-live-p swin) (not (eq ... ...))) (interactive-p))) (when (window-dedicated-p (get-buffer-window "*Completions*" (quote visible))) (condition-case nil (icicle-delete-windows-on "*Completions*") (error nil))) (bury-buffer (get-buffer "*Completions*"))))) * icicle-remove-Completions-window(FORCE) * (if (not (active-minibuffer-window)) (when (get-buffer "*Completions*") (kill-buffer (get-buffer "*Completions*"))) (icicle-remove-Completions-window (quote FORCE))) icicle-abort-recursive-edit() call-interactively(icicle-abort-recursive-edit nil nil) Thx - Drew