From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kelly Dean Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Run hook when variable is set Date: Thu, 29 Jan 2015 08:20:27 +0000 Message-ID: <7Dw4GTuMVOnntNGptSuTBkSMdmkHqNdTLkatZ8yKiM7@local> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1422519718 12771 80.91.229.3 (29 Jan 2015 08:21:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 29 Jan 2015 08:21:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 29 09:21:57 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YGkMO-0002qw-Hf for ged-emacs-devel@m.gmane.org; Thu, 29 Jan 2015 09:21:56 +0100 Original-Received: from localhost ([::1]:58181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGkMO-0007lA-0g for ged-emacs-devel@m.gmane.org; Thu, 29 Jan 2015 03:21:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGkMA-0007k7-AV for emacs-devel@gnu.org; Thu, 29 Jan 2015 03:21:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGkM4-0007Eo-My for emacs-devel@gnu.org; Thu, 29 Jan 2015 03:21:42 -0500 Original-Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:52059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGkM4-0007Eh-HG for emacs-devel@gnu.org; Thu, 29 Jan 2015 03:21:36 -0500 Original-Received: from mfilter17-d.gandi.net (mfilter17-d.gandi.net [217.70.178.145]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id B87DDFB8AC; Thu, 29 Jan 2015 09:21:35 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter17-d.gandi.net Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by mfilter17-d.gandi.net (mfilter17-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id pVKJDqQuCytq; Thu, 29 Jan 2015 09:21:34 +0100 (CET) X-Originating-IP: 66.220.3.179 Original-Received: from localhost (gm179.geneticmail.com [66.220.3.179]) (Authenticated sender: kelly@prtime.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 87352FB8B1; Thu, 29 Jan 2015 09:21:31 +0100 (CET) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4b98:c:538::198 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181965 Archived-At: Stefan Monnier wrote: > NACK from me. Why? Just because of the slowdown for symbols that have property lists? Or some additional reason? I.e. if I eliminate the slowdown, then will you still have an objection to the feature? > All that just to avoid using the minor mode? The updated patch I sent you does make dynamic-cursor-mode be a minor mode rather than a defcustom, because you said you want it to be a minor mode. I didn't implement varhook in order to avoid that. > I already posted the code > that I think should be used for that minor mode. And I explained why your code doesn't provide a complete solution. You didn't respond. I implemented varhook to completely solve the problem of dynamic-cursor-mode interfering with other uses of cursor-type in all cases, while ensuring that dynamic-cursor-mode itself can reliably be (re)enabled in all cases. Obviously, there are additional uses for this feature too. For just one example, without varhook, what solution would you propose for bug #19068?