From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59490: 29.0.50; Add C# support Date: Wed, 23 Nov 2022 15:03:53 -0800 Message-ID: <7DF363CA-3DE7-4477-B9C5-01558FDAC814@gmail.com> References: <0D2B024A-7486-46A4-999C-453494A251D6@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24006"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 59490@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 00:05:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxyo2-0005w7-AD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 00:05:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxyni-0000xc-IO; Wed, 23 Nov 2022 18:05:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxynh-0000xU-Hi for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 18:05:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxyne-0006wJ-Ii for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 18:05:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxyne-00052W-8g for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 18:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 23:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59490 X-GNU-PR-Package: emacs Original-Received: via spool by 59490-submit@debbugs.gnu.org id=B59490.166924464319293 (code B ref 59490); Wed, 23 Nov 2022 23:05:02 +0000 Original-Received: (at 59490) by debbugs.gnu.org; 23 Nov 2022 23:04:03 +0000 Original-Received: from localhost ([127.0.0.1]:56546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxymh-000517-1g for submit@debbugs.gnu.org; Wed, 23 Nov 2022 18:04:03 -0500 Original-Received: from mail-pg1-f176.google.com ([209.85.215.176]:39453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxyme-00050d-S9 for 59490@debbugs.gnu.org; Wed, 23 Nov 2022 18:04:01 -0500 Original-Received: by mail-pg1-f176.google.com with SMTP id 6so96775pgm.6 for <59490@debbugs.gnu.org>; Wed, 23 Nov 2022 15:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0GLNd0jDdvRXFf2YmXr6MFaTl9WjTLex+V5QvJzAL+I=; b=iBbkSmCDArN18j85jfeFD9v4/3JRzFRnG+XAv/o0YVrjgH5C3M1pF5s1j2JTrcAqNk GU1l4d+Gbvuer8McoFfJ1efWAzwyPkDD7Rt1cHJR0eULo4Q9VFBXLQ26UyEQi38OSc73 smYLtzXdug+UaQzwxEW4ZP+/ok7Ylu1D0P8TY4HisfgA5xPWnJvC+9tzWEJfhLiE39ZM hGfzF24J/j/kaqfHuUpu5eLrEH1qEsd5tZIvZZiTIkLc2/32rTR1+FLHyoSuI5POJii4 s7TtfLd8LJf1+Qi3Kv6aUOP43MnIYb3p74CmEHfWRLaCBuqVEQ9ZdHAVfbdvMl4iRyw0 jQAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0GLNd0jDdvRXFf2YmXr6MFaTl9WjTLex+V5QvJzAL+I=; b=DJa+D1IERPsaZ40DgoOeQcdHYbdG3Ym4IWEePx2pHbzaN9EQh3A7+6K2tMmUPnHCKo Gy/G48FOnZJ93sP/pWWrnYtYeFkc6pvBuDHIdecKTHpeBSxPU/k3fBbbXJQAl37shdXe neziIBQk35FsqmXViw7o39EPOJb5b2mMGAWiMhsLV/TQfwz1uBd5+VBQwAj+zv97QESI hdeXVWbUtcnLZLj6n3BbwPgzVLX2p4R2HJ0B2sEWgsxAS/N0u9CSm73SsUBJkKOzquG8 9dP6NMYbTvfOz/2Td8TEmrL9zS5miyM2ZEvblQ8f021NMA3T2FA0Vw7PXQHbhrSJLrVp MROA== X-Gm-Message-State: ANoB5pkMacFVojA0JYaPToWpdzmDHXNZidOr6RcqvzOD/tyGgTCW3nGT UQdSlxBsp09lAWaIpvbQasTwXmUH05/cIg== X-Google-Smtp-Source: AA0mqf7UYT+f0ynVhFAD7QVsuDQrssl7REKauNy6TRxfik/JPpnS8W9nkWf+7LoTnTP/NhmcrWV6ag== X-Received: by 2002:a63:4b0f:0:b0:464:203c:b964 with SMTP id y15-20020a634b0f000000b00464203cb964mr10138664pga.270.1669244634939; Wed, 23 Nov 2022 15:03:54 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id q2-20020aa79822000000b005743cdde1b8sm2292427pfl.127.2022.11.23.15.03.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2022 15:03:54 -0800 (PST) In-Reply-To: <0D2B024A-7486-46A4-999C-453494A251D6@thornhill.no> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248792 Archived-At: > On Nov 23, 2022, at 1:25 PM, Theodor Thornhill = wrote: >=20 >=20 >=20 > On 23 November 2022 22:19:21 CET, Yuan Fu wrote: >>=20 >>=20 >>> On Nov 23, 2022, at 12:43 PM, Theodor Thornhill = wrote: >>>=20 >>>=20 >>>=20 >>> On 23 November 2022 21:38:19 CET, Yuan Fu wrote: >>>>=20 >>>> Yuan Fu writes: >>>>=20 >>>>> Eli Zaretskii writes: >>>>>=20 >>>>>>> Date: Tue, 22 Nov 2022 22:47:12 +0100 >>>>>>> From: Theodor Thornhill via "Bug reports for GNU Emacs, >>>>>>> the Swiss army knife of text editors" >>>>>>>=20 >>>>>>> Ok so this works. >>>>>>>=20 >>>>>>> Sorry for the mess. >>>>>>>=20 >>>>>>> What do you think? >>>>>>=20 >>>>>> LGTM, thanks. I'll let Yuan review and install. >>>>>=20 >>>>> Thanks Theo! I=E2=80=99ve merged it. One general comment is that = we should have >>>>> a "standard" list of features consistent across major modes. I = think by >>>>> now we=E2=80=99ve worked on font-lock enough to know what those = features should >>>>> be. I=E2=80=99ll start a discussion on the ML. >>>>=20 >>>> Actually, another thing: it seems the mode defined is still named >>>> csharp-mode rather than csharp-cc-mode. >>>>=20 >>>> Yuan >>>=20 >>> Yeah that's right. Imo that's ok, because it's unlikely there will = be much new development on the cc mode variant. So it will be identical = to the upstream one, and the upstream one will be marked as deprecated = very soon. >>>=20 >>> What do you think? >>=20 >> Yeah I was just confused because you said >>=20 >>> I made two new modes, 'csharp-cc-mode' and 'csharp-ts-mode'. The = cc-mode >>> variant has that name as to not conflict with the ELPA package. >=20 > Yep, that was unclear. I decided to skip it in the second patch :) >=20 >>=20 >> And I only see csharp-mode. >>=20 >> So the mode we provide in Emacs are csharp-mode and csharp-ts-mode? = Then I assume this line is a typo? >>=20 >> ;;;###autoload >> (add-to-list 'auto-mode-alist '("\\.cs\\'" . csharp-cc-mode)) >>=20 >> Yuan >>=20 >=20 > That's correct. That's a typo. My bad :) make it csharp-mode. You want = a new patch? I applied the patch with that change :-) Yuan