From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master fd54102: * lisp/files.el (file-size-function): New defcustom Date: Sat, 20 Jul 2019 19:30:26 +0200 Message-ID: <7D6BBD73-017F-4A2D-9CBC-0EF67FBF5CC3@acm.org> References: <20190719165710.17673.32987@vcs0.savannah.gnu.org> <20190719165711.741F1206A7@vcs0.savannah.gnu.org> <87tvbgabra.fsf@tcd.ie> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_2B0DE782-F815-4283-8713-144C7DCA125D" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="99890"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Oleh Krehel , Emacs developers To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 20 19:30:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hotBt-000PrF-LZ for ged-emacs-devel@m.gmane.org; Sat, 20 Jul 2019 19:30:37 +0200 Original-Received: from localhost ([::1]:52290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hotBs-00078P-Ll for ged-emacs-devel@m.gmane.org; Sat, 20 Jul 2019 13:30:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39761) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hotBp-00078J-D2 for emacs-devel@gnu.org; Sat, 20 Jul 2019 13:30:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hotBo-0001YY-Fg for emacs-devel@gnu.org; Sat, 20 Jul 2019 13:30:33 -0400 Original-Received: from mail173c50.megamailservers.eu ([91.136.10.183]:42084 helo=mail56c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hotBo-0001Ww-15 for emacs-devel@gnu.org; Sat, 20 Jul 2019 13:30:32 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1563643829; bh=iQ0WCkxgBf9zgaDl6GlUSzS1e3PlwMSQxkytcSBsVdc=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=qwmQnSxG3j03RCKv0GLxT1qtJRWS0xZPByHFQ4qVPnVV0NLG+Sbx+y6nAzERA/qLA u2dk3tmWCq/nIvmV5NSauaG55hav5l/GanieZBdcWZ2bvL/hBEpVZw0qcINqdS9Hxr YI4ceiBA6sbilpx0eCEnCQgRAXFnsWNjVxUntwFk= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x6KHURdi023686; Sat, 20 Jul 2019 17:30:28 +0000 In-Reply-To: <87tvbgabra.fsf@tcd.ie> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0207.5D334FB5.0009, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=DI6hHRFb c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=Oruj8Z5LIicuEduDKuMA:9 a=CjuIK1q_8ugA:10 a=tl7BNfCTU-lK9B7bPJEA:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.183 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238739 Archived-At: --Apple-Mail=_2B0DE782-F815-4283-8713-144C7DCA125D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 20 juli 2019 kl. 18.53 skrev Basil L. Contovounesios : >=20 > [I wish changes like this (and its recent predecessors, which caused > test failues that others had to fix), even if small, to central > user-facing features were instead discussed and tested a little before > being unilaterally pushed.] So sorry for breaking things, and I'll be more careful. Surely the right = correction is to fix the test, unless the change itself somehow was = deemed questionable (which I never saw any indication of)? Proposed patch attached. With it applied, the test passes again. --Apple-Mail=_2B0DE782-F815-4283-8713-144C7DCA125D Content-Disposition: attachment; filename=0001-Make-tramp-test-regexp-more-robust.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Make-tramp-test-regexp-more-robust.patch" Content-Transfer-Encoding: quoted-printable =46rom=20a6ef72c0b6bea52d359858e519ea050a071f1d1c=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sat,=2020=20Jul=202019=2019:16:38=20+0200=0A= Subject:=20[PATCH]=20Make=20tramp=20test=20regexp=20more=20robust=0A=0A*=20= test/lisp/net/tramp-tests.el=20(tramp-test17-insert-directory):=0AMatch=20= a=20greater=20variety=20of=20human-readable=20size=20values.=0A---=0A=20= test/lisp/net/tramp-tests.el=20|=202=20+-=0A=201=20file=20changed,=201=20= insertion(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/test/lisp/net/tramp-tests.el=20b/test/lisp/net/tramp-tests.el=0Aindex=20= 64ba0414e8..1404ef39d5=20100644=0A---=20a/test/lisp/net/tramp-tests.el=0A= +++=20b/test/lisp/net/tramp-tests.el=0A@@=20-2827,7=20+2827,7=20@@=20= tramp--test-print-duration=0A=20=09=20=20=20=20=20=20=20(looking-at-p=0A=20= =09=09(concat=0A=20=09=09=20;;=20There=20might=20be=20a=20summary=20= line.=0A-=09=09=20"\\(total.+[[:digit:]]+[KMGTPEZY]?\n\\)?"=0A+=09=09=20= "\\(total.+[[:digit:]]+=20?[kKMGTPEZY]?i?B?\n\\)?"=0A=20=09=09=20;;=20We=20= don't=20know=20in=20which=20order=20".",=20".."=20and=20"foo"=20appear.=0A= =20=09=09=20(format=0A=20=09=09=20=20"\\(.+=20%s\\(=20= ->.+\\)?\n\\)\\{%d\\}"=0A--=20=0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_2B0DE782-F815-4283-8713-144C7DCA125D--