all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: JD Smith <jdtsmith@gmail.com>
To: 67023@debbugs.gnu.org
Subject: bug#67023: comint comments commend field=input
Date: Thu, 9 Nov 2023 13:24:36 -0500	[thread overview]
Message-ID: <7CE71ACE-95DA-4673-9804-054FD09983FB@gmail.com> (raw)


comint.el contains the following comment at line 1959, applicable when comint-use-prompt-regexp=nil:

                ;; Give old user input a field property of `input', to
                ;; distinguish it from both process output and unsent
                ;; input.  The terminating newline is put into a special
                ;; `boundary' field to make cursor movement between input
                ;; and output fields smoother.

But this is not actually done.  Just as for unsent input at the process mark, old input has text property field=nil.

I traced it back and this change was made in Emacs 22, at the same time overlay properties for the various comint fields were replaced by text properties.  Perhaps this is the desired behavior, and only fixing the comments is required.  However, the stated rationale to “distinguish from output and current unsent input” still seems applicable.  

Note that `comint-next-prompt’ checks explicitly for a null field value to know when it has moved past a prompt.  Comments in that function erroneously mention field=nil as pertaining only to unsent input at the end of the comint buffer. 




                 reply	other threads:[~2023-11-09 18:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7CE71ACE-95DA-4673-9804-054FD09983FB@gmail.com \
    --to=jdtsmith@gmail.com \
    --cc=67023@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.