From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation Date: Wed, 22 May 2019 12:52:08 +0200 Message-ID: <7C514C39-A204-44F4-A806-0B7DC3F4E6B4@acm.org> References: <91DFE4D0-BDB6-4365-BA51-A2A3F209177C@acm.org> <752237291204505cd6b3fb98f667c2718fa6361f.camel@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="70635"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35770@debbugs.gnu.org, vibhavp@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 22 12:53:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTOs2-000I5y-4U for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2019 12:53:18 +0200 Original-Received: from localhost ([127.0.0.1]:40095 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTOs1-0003bn-03 for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2019 06:53:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTOrn-0003X0-7a for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 06:53:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTOrm-0005bg-AG for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 06:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56303) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTOrm-0005bY-7A for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 06:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hTOrm-0005ik-3m for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 06:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 May 2019 10:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35770 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, vibhavp@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.155852234821929 (code B ref -1); Wed, 22 May 2019 10:53:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 May 2019 10:52:28 +0000 Original-Received: from localhost ([127.0.0.1]:41613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTOrD-0005hd-TD for submit@debbugs.gnu.org; Wed, 22 May 2019 06:52:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTOrB-0005hP-3O for submit@debbugs.gnu.org; Wed, 22 May 2019 06:52:25 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:44820) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTOr5-0005J9-Tk for submit@debbugs.gnu.org; Wed, 22 May 2019 06:52:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTOr4-0003Fk-Dq for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 06:52:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTOr3-0005Hs-IW for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 06:52:18 -0400 Original-Received: from mail232c50.megamailservers.eu ([91.136.10.242]:50192 helo=mail37c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTOr2-0005EA-UP for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 06:52:17 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1558522331; bh=Q/P9lZUd8JFINCPjeZYQJ+Q0OVONIoL2B8NvLd/HUZs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=CY+3wuFna6AV17dYgpddoS+ra37urpS5jzv/vAnv273pAJzbg+OXqsBEDH7TTzrGL e4zokkfm+w+YPYfHuOnOMuHurnyoykwCRQ2ro7H1yk7YFugkXIMhDTBlhHHtw/i46q /XvOwdz+fmMe4ftijky0fF8M5Bnwg6lmHatW+m4M= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4MAq89m000744; Wed, 22 May 2019 10:52:10 +0000 In-Reply-To: <752237291204505cd6b3fb98f667c2718fa6361f.camel@acm.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020F.5CE529DB.005A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ItQwjo3g c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=_G2kuTXN4iDmUCl-uu4A:9 a=CjuIK1q_8ugA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159643 Archived-At: No hurry in reviewing the patch, but since this is a wrong-code bug, I = suppose it should be back-ported to emacs-26. Does that mean that it = should be written for that branch and then merged to master, or the = other way around? The test uses bignums for numbers that aren't eq. In Emacs 26, those = would be floats instead, but bignums seemed more robust since it's not = unreasonable to have unboxed floats in the future.