From: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
To: emacs-devel@gnu.org
Cc: "João Távora" <joaotavora@gmail.com>
Subject: Should (icomplete-mode) explicitly disable fido-mode?
Date: Thu, 4 Jun 2020 10:49:05 -0700 [thread overview]
Message-ID: <7ADEE954-6074-4C8E-9EB7-7BF93F6F46BD@schwartzmeyer.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
Hi João,
I was wondering if this bit of code in icomplete-mode needs to be changed:
(when icomplete-mode
(fido-mode -1)...
Running (icomplete-mode) explicitly disables fido-mode, whereas running (fido-mode) makes it appear that icomplete-mode is enabled (sets it to t and runs its setup, without actually running the function icomplete-mode).
This causes third party packages which wrap icomplete-mode to easily break fido-mode, like in this issue: https://github.com/oantolin/icomplete-vertical/pull/13 <https://github.com/oantolin/icomplete-vertical/pull/13>
icomplete-vertical calls (icomplete-mode), I think expecting it to be idempotent (not have any effect if icomplete-mode is already enabled), but in fact, since fido-mode is currently enabled this explicitly disables it and switches to the base icomplete-mode, as the mode functions icomplete-mode and fido-mode act like toggles of each other.
Should (icomplete-mode t) perhaps do nothing if fido-mode is already enabled? I’m not sure. Obviously the package can workaround it (given my patch), but I think it’s unexpected to have to avoid calling (icomplete-mode) if the icomplete-mode var is already t. What do you think?
Thanks,
Andy
[-- Attachment #2: Type: text/html, Size: 1921 bytes --]
next reply other threads:[~2020-06-04 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 17:49 Andrew Schwartzmeyer [this message]
2020-06-05 22:48 ` Should (icomplete-mode) explicitly disable fido-mode? João Távora
2020-06-05 23:19 ` Stefan Monnier
2020-06-06 5:14 ` Andrew Schwartzmeyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ADEE954-6074-4C8E-9EB7-7BF93F6F46BD@schwartzmeyer.com \
--to=andrew@schwartzmeyer.com \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.