From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.devel Subject: Re: Proposal to add Popper to ELPA Date: Tue, 5 Sep 2023 17:37:26 -0300 Message-ID: <79d3a26e-ee98-470d-1b26-8e2b17ba6718@gmail.com> References: <874jk8ef0k.fsf@gmail.com> <87y1hkcygb.fsf@posteo.net> <87zg20crbh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28759"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: emacs-devel@gnu.org, Philip Kaludercic To: Karthik Chikmagalur Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 05 22:38:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdcoX-0007KJ-SW for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Sep 2023 22:38:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdcnn-00065r-TQ; Tue, 05 Sep 2023 16:37:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdcnl-00065K-Vd for emacs-devel@gnu.org; Tue, 05 Sep 2023 16:37:34 -0400 Original-Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdcnj-0007yv-PJ for emacs-devel@gnu.org; Tue, 05 Sep 2023 16:37:33 -0400 Original-Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-5733bcf6eb6so1617413eaf.0 for ; Tue, 05 Sep 2023 13:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693946250; x=1694551050; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C1IFc4ufDW4X1ukEbAuVd910fvaqShhDyKoaLjJpdF8=; b=DirexaFUnH5gf8VTqN4rWvz5ie0hbVp/yucRRvdPzhJPWGJSBi3Nzb0/ttvHlocM8G o5eWfGw9mBGXR3bK5MeDhQuifsghDEn8iGqt6H+ewlmSU1+NPYKWa0dikw22N8bgAYo4 Jrj+yfvnddhFFTNMd/THtrNjpae/gzeay4Qc6Prpc1k+WB7Ra+Ez8YseQE+u+KsJ0y10 S5Tn9uICvrEtCcbBppFIhopOgqrqbNA8G4a9cW5dmPwwFOVcTxmor5deWkgm0yydinrQ XdNTN9iLMvdDHU/ah5jp2tulJaYHeYH7C6fSXH23ktHR7ufJRFOZVxUPAJBL/FkM69Tf 3QuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693946250; x=1694551050; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C1IFc4ufDW4X1ukEbAuVd910fvaqShhDyKoaLjJpdF8=; b=KuxJsXBuK1Hi8mvHpFmPBGuKmbzd8eE3MfJ9HfZY7tmcny7E2lIiY29sE0QaVM2/Dz jAgV0U52VHulbESINrssW2or4k55Y99u4Z6Cdqz5Tl1KrhO0lOfWw6jjLczs/RWFf47V tUmti0apxAah7Y6kc2sMgBmU9Alh5IvY1Ak3750VVHKWstDszzSySG85T37YsAOTihVm kMgjwlnhhBFPQVZB0yCzbcb8ADcHsg2a505u5WFJAha4UZ4NvlG7LduCCwqAfG1HLDnf FKX7dg5DBUILqzI9v0ymZJVNsmiltThvnzj798o3VG87hzt1tnUbEz73f0Tj1fLXsH+4 CeJw== X-Gm-Message-State: AOJu0YxjikqAKHHGDDhEzD3c85eCRzpS9I0zRo5kZXxKDZoxvqME0zvw uT0qF2GjstSGvPY9fS0Xk4Q= X-Google-Smtp-Source: AGHT+IGn4EtQynadxrqX3gf1f/2gUPmgry9auMtHdhHBI+avRZVzG07Rk/nc2mBiG+UjdLiSGaChJA== X-Received: by 2002:a05:6820:284:b0:573:2863:2926 with SMTP id q4-20020a056820028400b0057328632926mr11068965ood.8.1693946250419; Tue, 05 Sep 2023 13:37:30 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id 68-20020a4a1d47000000b00570bc62a8d4sm6344678oog.29.2023.09.05.13.37.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 13:37:29 -0700 (PDT) Content-Language: en-US In-Reply-To: <87zg20crbh.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::c2b; envelope-from=maurooaranda@gmail.com; helo=mail-oo1-xc2b.google.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.473, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310154 Archived-At: On 5/9/23 17:12, Karthik Chikmagalur wrote: > In case you missed it during the review, the package has two files: > `popper.el' and `popper-echo.el'. (The latter provides `popper-echo-mode', > which adds echo-area display of available popups and allows for quick > selection using a transient keymap.) I took a look at the defcustoms in popper-echo.el. Here are my proposed changes: diff --git a/popper-echo.el b/popper-echo.el index 0369840..b19d7cb 100644 --- a/popper-echo.el +++ b/popper-echo.el @@ -58,7 +58,8 @@ This is called on buffer-names displayed by `popper-echo'. This function should accept a string (the buffer name) and return a transformed string." - :type 'function + :type '(choice (const :tag "Don't transform buffer-names" nil) + function) :group 'popper) (defcustom popper-echo-lines 2 @@ -102,7 +103,7 @@ Examples: This variable has no effect when popper-echo-mode is turned off." - :type '(group character string) + :type '(repeat (choice character string)) :group 'popper) (defface popper-echo-area-buried