From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Angelo Graziosi Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0c94b84: * nt/inc/ms-w32.h (execve) [MINGW_W64]: Make commentary more accurate. Date: Sun, 4 Sep 2016 22:58:26 +0200 Message-ID: <79ce71b0-cce2-79c8-7aa1-4854c8ce8192@alice.it> References: <20160901171604.9042.16589@vcs.savannah.gnu.org> <20160901171604.8DF4D22016A@vcs.savannah.gnu.org> <518bc279-ee83-356a-51af-fd348d32aa4f@cornell.edu> <83vayeeqsh.fsf@gnu.org> <7f482669-53eb-a22d-54bf-a781a36b46de@alice.it> <08271c31-cebb-62d7-86d4-366a0e1446ed@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1473022736 7776 195.159.176.226 (4 Sep 2016 20:58:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Sep 2016 20:58:56 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 Cc: emacs-devel@gnu.org To: Paul Eggert , Eli Zaretskii , Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 04 22:58:52 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgeVA-0001cZ-86 for ged-emacs-devel@m.gmane.org; Sun, 04 Sep 2016 22:58:52 +0200 Original-Received: from localhost ([::1]:51041 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgeV7-00030b-TW for ged-emacs-devel@m.gmane.org; Sun, 04 Sep 2016 16:58:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgeV1-00030J-M3 for emacs-devel@gnu.org; Sun, 04 Sep 2016 16:58:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgeUw-0003U4-MB for emacs-devel@gnu.org; Sun, 04 Sep 2016 16:58:43 -0400 Original-Received: from smtp203.alice.it ([82.57.200.99]:54992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgeUw-0003Tq-9w; Sun, 04 Sep 2016 16:58:38 -0400 Original-Received: from [192.168.1.100] (79.45.0.244) by smtp203.alice.it (8.6.060.43) (authenticated as angelo.graziosi@alice.it) id 57AB225A038139B1; Sun, 4 Sep 2016 22:58:35 +0200 In-Reply-To: <08271c31-cebb-62d7-86d4-366a0e1446ed@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 82.57.200.99 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207183 Archived-At: Il 04/09/2016 20:47, Paul Eggert ha scritto: > I'd rather keep the mainline code as free from such ifdefs as possible. > > If the problem is that GCC complains about execvp due to some > configuration problem on MS-Windows, perhaps you could put a wrapper > into w32common.h or some similar location, to pacify the compiler. > emacsclient.c already uses such a wrapper, for another reason. It would be better to continue to have all those warnings! I still think that Ken's solution is the most elegant. In any case, Eli's patch is better than this proposal... Angelo