From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#35868: [PATCH] `memql' does not work for bignums Date: Thu, 23 May 2019 17:07:11 +0200 Message-ID: <79AE2738-3B42-410A-AA9A-F0FDE7865162@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_5A78E11F-5E5E-4D38-BCB4-D57CC9A4D1A2" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="99421"; mail-complaints-to="usenet@blaine.gmane.org" To: 35868@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 23 17:42:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTpr9-000PgC-24 for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 May 2019 17:42:11 +0200 Original-Received: from localhost ([127.0.0.1]:39121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTpr8-0005q9-3q for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 May 2019 11:42:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTpr1-0005pn-Tp for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 11:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTpr1-0004OU-4s for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 11:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59756) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTpr1-0004OL-1L for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 11:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hTpr0-0007FR-TT for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 11:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 May 2019 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35868 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155862608227811 (code B ref -1); Thu, 23 May 2019 15:42:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 May 2019 15:41:22 +0000 Original-Received: from localhost ([127.0.0.1]:45067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTpqM-0007EV-3d for submit@debbugs.gnu.org; Thu, 23 May 2019 11:41:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTpqJ-0007EH-N7 for submit@debbugs.gnu.org; Thu, 23 May 2019 11:41:20 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:60646) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTpqE-0003NL-Hr for submit@debbugs.gnu.org; Thu, 23 May 2019 11:41:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTpqD-0005iB-Mm for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 11:41:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTpqC-0003MA-RE for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 11:41:13 -0400 Original-Received: from mail1425c50.megamailservers.eu ([91.136.14.25]:54710 helo=mail102c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTpqC-0003Je-9a for bug-gnu-emacs@gnu.org; Thu, 23 May 2019 11:41:12 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1558624035; bh=xSyEpAkOabuf3x3OXzlNp/JMEKOBJ2q4o4uLLkladOw=; h=From:Subject:Date:To:From; b=c3o1opQhd/P9OFF7dCXW60m4YxgVcGT3fI49HHixqqaq36drmigCrnyKm0mAHs4Tc Bkb5yChpvLmS7OW5V448dMeOh35Bo/C1s7GioO4X9aowsfy7mmaNvB6H308ytOJFp4 J9T5N1U0sRKf+Uzxz8GuQjkjcHO/IY6TFSLi6AVc= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x4NF7CgO031586 for ; Thu, 23 May 2019 15:07:14 +0000 X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0213.5CE6B723.0001, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=F7x5iJpN c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=xq1mYcpEdMbUi_Uk5wIA:9 a=CjuIK1q_8ugA:10 a=sCsws7hTipOt-NdtaxUA:9 a=B2y7HmGcmWMA:10 a=0aE9QUaO_QmmuWBIoxcA:9 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159682 Archived-At: --Apple-Mail=_5A78E11F-5E5E-4D38-BCB4-D57CC9A4D1A2 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii (memql (ash 1 100) (list (ash 1 100))) => nil Proposed patch attached. --Apple-Mail=_5A78E11F-5E5E-4D38-BCB4-D57CC9A4D1A2 Content-Disposition: attachment; filename=0001-Fix-memql-for-bignums.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-memql-for-bignums.patch" Content-Transfer-Encoding: quoted-printable =46rom=20afe2c459cff312e8c378e8381a36110f444dcb01=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Thu,=2023=20May=202019=2017:01:27=20+0200=0A= Subject:=20[PATCH]=20Fix=20`memql'=20for=20bignums=0A=0A*=20src/fns.c=20= (Fmemql):=20Make=20`memql'=20work=20for=20bignums.=0A*=20= test/src/fns-tests.el=20(test-bignum-eql):=20Also=20test=20`memql'.=0A= ---=0A=20src/fns.c=20=20=20=20=20=20=20=20=20=20=20=20=20|=2034=20= ++++++++++++++++++++++++----------=0A=20test/src/fns-tests.el=20|=20=203=20= ++-=0A=202=20files=20changed,=2026=20insertions(+),=2011=20deletions(-)=0A= =0Adiff=20--git=20a/src/fns.c=20b/src/fns.c=0Aindex=20= 6b1f7331f5..da830a9000=20100644=0A---=20a/src/fns.c=0A+++=20b/src/fns.c=0A= @@=20-1567,18=20+1567,32=20@@=20DEFUN=20("memql",=20Fmemql,=20Smemql,=20= 2,=202,=200,=0A=20The=20value=20is=20actually=20the=20tail=20of=20LIST=20= whose=20car=20is=20ELT.=20=20*/)=0A=20=20=20(Lisp_Object=20elt,=20= Lisp_Object=20list)=0A=20{=0A-=20=20if=20(!FLOATP=20(elt))=0A-=20=20=20=20= return=20Fmemq=20(elt,=20list);=0A-=0A-=20=20Lisp_Object=20tail=20=3D=20= list;=0A-=20=20FOR_EACH_TAIL=20(tail)=0A+=20=20if=20(FLOATP=20(elt))=0A=20= =20=20=20=20{=0A-=20=20=20=20=20=20Lisp_Object=20tem=20=3D=20XCAR=20= (tail);=0A-=20=20=20=20=20=20if=20(FLOATP=20(tem)=20&&=20same_float=20= (elt,=20tem))=0A-=09return=20tail;=0A+=20=20=20=20=20=20Lisp_Object=20= tail=20=3D=20list;=0A+=20=20=20=20=20=20FOR_EACH_TAIL=20(tail)=0A+=20=20=20= =20=20=20=20=20{=0A+=20=20=20=20=20=20=20=20=20=20Lisp_Object=20tem=20=3D=20= XCAR=20(tail);=0A+=20=20=20=20=20=20=20=20=20=20if=20(FLOATP=20(tem)=20= &&=20same_float=20(elt,=20tem))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= return=20tail;=0A+=20=20=20=20=20=20=20=20}=0A+=20=20=20=20=20=20= CHECK_LIST_END=20(tail,=20list);=0A+=20=20=20=20=20=20return=20Qnil;=0A=20= =20=20=20=20}=0A-=20=20CHECK_LIST_END=20(tail,=20list);=0A-=20=20return=20= Qnil;=0A+=20=20else=20if=20(BIGNUMP=20(elt))=0A+=20=20=20=20{=0A+=20=20=20= =20=20=20Lisp_Object=20tail=20=3D=20list;=0A+=20=20=20=20=20=20= FOR_EACH_TAIL=20(tail)=0A+=20=20=20=20=20=20=20=20{=0A+=20=20=20=20=20=20= =20=20=20=20Lisp_Object=20tem=20=3D=20XCAR=20(tail);=0A+=20=20=20=20=20=20= =20=20=20=20if=20(equal_no_quit=20(elt,=20tem))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20return=20tail;=0A+=20=20=20=20=20=20=20=20}=0A+=20=20=20=20=20= =20CHECK_LIST_END=20(tail,=20list);=0A+=20=20=20=20=20=20return=20Qnil;=0A= +=20=20=20=20}=0A+=20=20else=0A+=20=20=20=20return=20Fmemq=20(elt,=20= list);=0A=20}=0A=20=0A=20DEFUN=20("assq",=20Fassq,=20Sassq,=202,=202,=20= 0,=0Adiff=20--git=20a/test/src/fns-tests.el=20b/test/src/fns-tests.el=0A= index=206ebab4287f..a9d4d11795=20100644=0A---=20a/test/src/fns-tests.el=0A= +++=20b/test/src/fns-tests.el=0A@@=20-614,7=20+614,8=20@@=20dot2=0A=20=20= =20=20=20(should=20(eq=20x=20x))=0A=20=20=20=20=20(should=20(eql=20x=20= y))=0A=20=20=20=20=20(should=20(equal=20x=20y))=0A-=20=20=20=20= (should-not=20(eql=20x=200.0e+NaN))))=0A+=20=20=20=20(should-not=20(eql=20= x=200.0e+NaN))=0A+=20=20=20=20(should=20(memql=20x=20(list=20y)))))=0A=20= =0A=20(ert-deftest=20test-bignum-hash=20()=0A=20=20=20"Test=20that=20= hash=20tables=20work=20for=20bignums."=0A--=20=0A2.20.1=20(Apple=20= Git-117)=0A=0A= --Apple-Mail=_5A78E11F-5E5E-4D38-BCB4-D57CC9A4D1A2 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_5A78E11F-5E5E-4D38-BCB4-D57CC9A4D1A2--