From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes Date: Thu, 3 Mar 2022 21:55:41 -0800 Message-ID: <797bb243-5397-bb8f-0902-7f96273e913f@gmail.com> References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> <83ilsxlsx0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------8008EEF1671273D56305E545" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38292"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 54190@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 04 06:56:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQ0vQ-0009kZ-FX for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Mar 2022 06:56:24 +0100 Original-Received: from localhost ([::1]:57242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQ0vO-0008QY-VS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Mar 2022 00:56:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ0v4-0008QO-Nc for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 00:56:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50517) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQ0v4-0007Zt-ET for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 00:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nQ0v4-0002gf-EI for bug-gnu-emacs@gnu.org; Fri, 04 Mar 2022 00:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Mar 2022 05:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54190-submit@debbugs.gnu.org id=B54190.164637335010307 (code B ref 54190); Fri, 04 Mar 2022 05:56:02 +0000 Original-Received: (at 54190) by debbugs.gnu.org; 4 Mar 2022 05:55:50 +0000 Original-Received: from localhost ([127.0.0.1]:44414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQ0us-0002gB-AB for submit@debbugs.gnu.org; Fri, 04 Mar 2022 00:55:50 -0500 Original-Received: from mail-pl1-f179.google.com ([209.85.214.179]:37517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQ0uq-0002fx-Ls for 54190@debbugs.gnu.org; Fri, 04 Mar 2022 00:55:49 -0500 Original-Received: by mail-pl1-f179.google.com with SMTP id n15so6844243plf.4 for <54190@debbugs.gnu.org>; Thu, 03 Mar 2022 21:55:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=xLSvBab8sRCT8b48nzbBpub6Z+L36PlVSuSdSjZkv6w=; b=koxC647cQ4huYMsp5jR63wS8Ct43+2w1XlsmnIwo9QReHVJgkVyHQE3K37i7XL6xX2 F32RVbEiGFiE3e+Pe/+WKjrHuzp6+h30KD9eqSKgvQmFl/TJLIWZuZUq9MuriKPF0NQt d+7oB7FKcRkIrXc0WC1M8dtxaDzrdimkrOhirYp49JIflfRiDnQQb+HvX0j8daxzoMcq UVdQziB5wq7X6k6E2JUJVhrSm5m9ZwtEstVS6ugrwS4L+KQy55kIbn2PN7Z+52rT2YPH QUFIpmk2qAdT36Z7aCK0u2+zbHBL5wAjO30ivtCSLdCwl9ynUu336qTN6xAxQ1Vds3Bf gGng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=xLSvBab8sRCT8b48nzbBpub6Z+L36PlVSuSdSjZkv6w=; b=25SK53DNsqB1N8B0QFeZ1K7PFQUygQwRAdAkS75vNuuIZSYzJA3RLRVDVIfHGDBCCA tlonoq3x0gwnYFY7t0OdS95Dt63Ec2vpoqF8fu+fi1vuV67Y0mVnnWg7v6tksCt2yuir 3yrpjD/IVXe6lt9IsfcmHPCSFH/g74X0zqcIFxZ1oMjOOuyOtQyWOTE4s0r0CNpmbH/Q 2omPiVQmF+SawR/OlIDjQYzyqU5mCAxJ/BR6Y5grxbSH7nckYFiKJ4ZEUoXPrFCLJJtz MJ90lAuNhd61VsKlmmwwbJZ5jLaFpYJ7NdhgdBeBxYXsNaeBaC23eY40LYGhgAm1XLkh rHYg== X-Gm-Message-State: AOAM532/QvcJ7TmppGk2JpFSDdgAwXpF+0mgkQl/5TyEruX7xkx1lRkD V9T8keemSWV8cAazCZNB7+Q= X-Google-Smtp-Source: ABdhPJxNvUNFvu/ESCkCq2M621xS16aakjeCFpwNriwYCbmPefsUAeoxYDn2C7PdAIn3NHiaKZvnkg== X-Received: by 2002:a17:90b:350c:b0:1bf:1dc5:1c3d with SMTP id ls12-20020a17090b350c00b001bf1dc51c3dmr4230921pjb.53.1646373342674; Thu, 03 Mar 2022 21:55:42 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a19-20020a17090ad81300b001bc447c2c91sm9585008pjv.31.2022.03.03.21.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 21:55:41 -0800 (PST) In-Reply-To: <83ilsxlsx0.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227987 Archived-At: This is a multi-part message in MIME format. --------------8008EEF1671273D56305E545 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 3/1/2022 5:10 AM, Eli Zaretskii wrote: > Thanks, installed on the emacs-28 branch. (But the markup in the > manual part was wrong; see my followup changes.) Thanks for fixing that up. > Fine with me. It's up to you whether to close this bug or leave it > open until a better solution is found for master. After a bit of looking at the `eshell-do-eval' implementation, I realized that there's a better solution that's very simple. See the attached patch. It's simple enough that it might be fine for Emacs 28, but the existing change on the 28 branch is probably a bit safer, since that change was just a partial revert. I'm not aware of anything that could be broken by this new patch, but you never know... This doesn't do anything more elaborate like using generator.el's machinery here; while (I think) that would be nice to have eventually, we can address that in a separate bug, since it'd be a pretty big change. We could probably close this bug after this new patch merges. --------------8008EEF1671273D56305E545 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-Eshell-s-command-forms-in-a-better-way.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-Eshell-s-command-forms-in-a-better-way.patch" RnJvbSA0ODM4N2U4MjdjZDhkNTUwZTk2MjdkZjcyNTZmZDNmMWE5NzA1YTI2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMyBNYXIgMjAyMiAyMTo0NjoxMSAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeCBFc2hlbGwncyAnJDxjb21tYW5kPicgZm9ybXMgaW4gYSBiZXR0ZXIgd2F5Cgoq IGxpc3AvZXNoZWxsL2VzaC1jbWQuZWwgKGVzaGVsbC1kby1ldmFsKTogSGFuZGxlICdsYW1i ZGEnIGZvcm1zLgoqIGxpc3AvZXNoZWxsL2VzaC12YXIuZWwgKGVzaGVsbC1wYXJzZS12YXJp YWJsZS1yZWYpOiBSZW1vdmUKd29ya2Fyb3VuZCBmcm9tIGNvbW1pdCA5ZTI1N2FlIChidWcj NTQxOTApLgotLS0KIGxpc3AvZXNoZWxsL2VzaC1jbWQuZWwgfCAyICstCiBsaXNwL2VzaGVs bC9lc2gtdmFyLmVsIHwgOCArKy0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlv bnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZXNoLWNt ZC5lbCBiL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKaW5kZXggMDRiNTRkOWQ3OS4uNDg0ODg4 ZWM0NyAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbAorKysgYi9saXNwL2Vz aGVsbC9lc2gtY21kLmVsCkBAIC0xMDc3LDcgKzEwNzcsNyBAQCBlc2hlbGwtZG8tZXZhbAog ICAoY29uZAogICAgKChub3QgKGxpc3RwIGZvcm0pKQogICAgIChsaXN0ICdxdW90ZSAoZXZh bCBmb3JtKSkpCi0gICAoKG1lbXEgKGNhciBmb3JtKSAnKHF1b3RlIGZ1bmN0aW9uKSkKKyAg ICgobWVtcSAoY2FyIGZvcm0pICcocXVvdGUgZnVuY3Rpb24gbGFtYmRhKSkKICAgICBmb3Jt KQogICAgKHQKICAgICA7OyBza2lwIHBhc3QgdGhlIGNhbGwgdG8gYGVzaGVsbC1kby1ldmFs JwpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZXNoLXZhci5lbCBiL2xpc3AvZXNoZWxsL2Vz aC12YXIuZWwKaW5kZXggYWY4OWUzNWY1NS4uMDkyZjlmODdhNCAxMDA2NDQKLS0tIGEvbGlz cC9lc2hlbGwvZXNoLXZhci5lbAorKysgYi9saXNwL2VzaGVsbC9lc2gtdmFyLmVsCkBAIC00 NTgsMTIgKzQ1OCw4IEBAIGVzaGVsbC1wYXJzZS12YXJpYWJsZS1yZWYKICAgICAgICAgICAg ICAgICAgICAgICAgKGVzaGVsbC1wYXJzZS1jb21tYW5kIGNtZCkpKQogICAgICAgICAgICAg ICAgICAgIChpZ25vcmUKICAgICAgICAgICAgICAgICAgICAgKG5jb25jIGVzaGVsbC10aGlz LWNvbW1hbmQtaG9vawotICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgUXVvdGUgdGhp cyBsYW1iZGE7IGl0IHdpbGwgYmUgZXZhbHVhdGVkCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICA7OyBieSBgZXNoZWxsLWRvLWV2YWwnLCB3aGljaCByZXF1aXJlcyB2ZXJ5Ci0gICAg ICAgICAgICAgICAgICAgICAgICAgICA7OyBwYXJ0aWN1bGFyIGZvcm1zIGluIG9yZGVyIHRv IHdvcmsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IHByb3Blcmx5LiAgU2VlIGJ1 ZyM1NDE5MC4KLSAgICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0IChmdW5jdGlvbiAo bGFtYmRhICgpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkZWxldGUt ZmlsZSAsdGVtcCkpKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxpc3QgKGxh bWJkYSAoKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLWZp bGUgLHRlbXApKSkpKQogICAgICAgICAgICAgICAgICAgIChxdW90ZSAsdGVtcCkpKQogICAg ICAgICAgICAgKGdvdG8tY2hhciAoMSsgZW5kKSkpKSkpKQogICAgKChlcSAoY2hhci1hZnRl cikgP1woKQotLSAKMi4yNS4xCgo= --------------8008EEF1671273D56305E545--