From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68765: 30.0.50; Adding window-tool-bar package. Date: Thu, 09 May 2024 21:24:02 -0700 Message-ID: <791456a05f91c68549027ea1ea33eaf6@finder.org> References: <07df5e8408054bcae5968066b0cebf34@finder.org> <86fry0vihy.fsf@gnu.org> <86fry08di9.fsf@mail.linkov.net> <86cyrg5hc0.fsf@mail.linkov.net> <865xvyoupe.fsf@mail.linkov.net> <86frur76uj.fsf@gnu.org> Reply-To: Jared Finder Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38396"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 68765@debbugs.gnu.org, monnier@iro.umontreal.ca, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 10 06:25:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s5Hp2-0009kY-5V for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 May 2024 06:25:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5Hof-0004tM-Ou; Fri, 10 May 2024 00:25:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5Hod-0004t9-Ll for bug-gnu-emacs@gnu.org; Fri, 10 May 2024 00:25:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s5Hod-0008HL-CL for bug-gnu-emacs@gnu.org; Fri, 10 May 2024 00:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s5Hob-000660-Qo for bug-gnu-emacs@gnu.org; Fri, 10 May 2024 00:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jared Finder Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2024 04:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68765 X-GNU-PR-Package: emacs Original-Received: via spool by 68765-submit@debbugs.gnu.org id=B68765.171531504523417 (code B ref 68765); Fri, 10 May 2024 04:25:01 +0000 Original-Received: (at 68765) by debbugs.gnu.org; 10 May 2024 04:24:05 +0000 Original-Received: from localhost ([127.0.0.1]:41517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5Hnh-00065d-3K for submit@debbugs.gnu.org; Fri, 10 May 2024 00:24:05 -0400 Original-Received: from greenhill.hpalace.com ([192.155.80.58]:41188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5Hnd-00065L-P7 for 68765@debbugs.gnu.org; Fri, 10 May 2024 00:24:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1715315042; bh=izzSLHscYYCaZHox99DznnmFt3zYDt9SqSkYoew3Uuw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cTuLiJ1jzdrT3y4nhYCaMaYRAaxCHe91t85pb+50sYHGMo23UpVIdehMd79Z4PEXZ ktP09XxYuGJD1XNX03T0DfwXXkmJ3YIX4uq+dQOr8CDNyiHZ8GSODini4ZimXWMH7g cp8YJ2u9vqD9lbgRFVHuAuG1Q8QuM/wZ8QK8e/zEKh7ANG74U4jE+6+x5uVyZBrK8O i03UF6pAJRoCReo1ltgPJUZaKdSDahJxJhZFNOcJllOK62bw8v/ya73whg+jCdV5oF wWiz44qm+vGwWJjWk/IQic+nL9gte6DqmuTSN/sk4TrTgXSIkis4yBxjfhmQVNXo90 cYheS5+7sxjdw== Original-Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 66FD1C4F; Fri, 10 May 2024 04:24:02 +0000 (UTC) In-Reply-To: <86frur76uj.fsf@gnu.org> X-Sender: jared@finder.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284794 Archived-At: On 2024-05-09 01:00, Eli Zaretskii wrote: >> From: Juri Linkov >> Cc: Eli Zaretskii , 68765@debbugs.gnu.org, Philip >> Kaludercic >> , Stefan Monnier >> Date: Thu, 02 May 2024 09:03:20 +0300 >> >> >> It's been four weeks and I've seen no reply to this comment. Are there any >> >> other concerns? >> > >> > Sorry, I didn't know that you expected that I should review your patch - >> > I was silent because your last patch has no changes in tab-line.el, >> > so I have no more objections in this regard. >> >> The reason why no changes are required in tab-line.el is >> because this feature is not exclusively for the tab line, >> so window-tool-bar.el should also handle the case >> when the tool bar is combined with the header line. >> For example, in Info mode the users might prefer to show >> the Info tool bar icons and Next/Prev/Up >> on the same header line. > > If there's an agreement about this issue, could you, Jared, please > post the final patch reflecting the agreements? > > If there's no agreement, what are the issues that prevent it? I'm unclear on what changes Juri would like to window-tool-bar.el. Sorry for the really long reply, I just want to make sure things are extra clear so I can proceed. First, let me share some additional information. window-tool-bar.el currently provides two ways for a user to put the tool bar buttons into tab line / header line / mode line: The command window-tool-bar-mode for simple enablement. The function window-tool-bar-string can be added as (:eval (window-tool-bar-string)) to tab-line-format, header-line-format, or mode-line-format programmatically for more advanced placement. I think the above interface is the right thing to have from a user perspective. Then the most straightforward thing would be to make M-x window-tool-bar-mode behave similar to M-x tab-line-mode: it would always put the tool bar on the tab line, and only make changes if nothing else changed tab-line-format. Additionally, I would make a very small change then to tab-line.el to display a message to the user if M-x tab-line-mode does not actually changing anything to avoid user confusion as this now can happen by running commands (M-x window-tool-bar-mode RET M-x tab-line-mode RET, for example). I would add similar messaging to window-tool-bar as well. Does this sound like a good plan? -- MJF