From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#34908: Push mark in xref-push-marker-stack Date: Thu, 21 Mar 2019 02:59:18 +0200 Message-ID: <789f35b5-7a33-286c-72ab-a9ebbf13d254@yandex.ru> References: <87h8bz29ht.fsf@mail.linkov.net> <871s32h91o.fsf@mail.linkov.net> <87lg192omi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="161829"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 Cc: 34908@debbugs.gnu.org, =?UTF-8?Q?jo=C3=A3o_?= =?UTF-8?Q?t=C3=A1vora?= To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 21 02:16:37 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6mJw-000fz9-Oc for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 02:16:36 +0100 Original-Received: from localhost ([127.0.0.1]:57746 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6mJv-0002rJ-N4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Mar 2019 21:16:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6mIK-0001LX-9Q for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 21:14:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h6m3v-0007JG-ON for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 21:00:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38985) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h6m3v-0007Iy-ER for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 21:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h6m3v-0000Af-94 for bug-gnu-emacs@gnu.org; Wed, 20 Mar 2019 21:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Mar 2019 01:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34908 X-GNU-PR-Package: emacs Original-Received: via spool by 34908-submit@debbugs.gnu.org id=B34908.1553129969578 (code B ref 34908); Thu, 21 Mar 2019 01:00:03 +0000 Original-Received: (at 34908) by debbugs.gnu.org; 21 Mar 2019 00:59:29 +0000 Original-Received: from localhost ([127.0.0.1]:52529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6m3N-00009G-G4 for submit@debbugs.gnu.org; Wed, 20 Mar 2019 20:59:29 -0400 Original-Received: from mail-lf1-f50.google.com ([209.85.167.50]:40289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h6m3L-000093-A7 for 34908@debbugs.gnu.org; Wed, 20 Mar 2019 20:59:27 -0400 Original-Received: by mail-lf1-f50.google.com with SMTP id u68so3338811lff.7 for <34908@debbugs.gnu.org>; Wed, 20 Mar 2019 17:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YriFJ0LOfuHnsCByE5JzVP94rcCgz+2ttHL9J51YgXw=; b=PRZkPN/Gk6mROk6G6p8dLTwL+etOgyGbivVd3ZGuzaunvE/R8zSJ3idk0g0XCLrVDP zBqPF1ZuiYDuEIm1RLY6sPaOhu6SqemOgiPegY7Vr2lTNfAqIYq6iGGJ02YAOzf2PAke m0n16R7d+mYGkOLxey8Pf6r/HjVTLE5Y4RkuYE66c+jLKKBh7hiEuJHflE6o+Ry3mDta LhZYKCEa0rkGOCoIjIDocJsxk5E6h9cUT+oSrtVCSCQNA5zWl8bf25yMJ5ES0+2gDs9w y+cN5dKfHrAl/mYXG3jCFPo0glgasR/m9PR4sfOoMO2mjdg6/ar/w9TaLlsgCVgyEtB/ QI8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YriFJ0LOfuHnsCByE5JzVP94rcCgz+2ttHL9J51YgXw=; b=OGjVvFIUBYjouZ+NxFoFOUEjawVS2/DcA88fWplh+UaavDmqUC8sXMOImhLCab4sit 08tlWjnIALfpFopIcqfocJ5jKMSnh/SMlJj6b8rzXlh2rXYCPtgKV6b5fg5RBrdRrMJL bGRSljrzSpydFWUyNXd8/bS9q/kD5YlZepVNJ6FBDVhh5JmG1kb5MdYPsMFXBD7hfJ7v pF+rtOpBJiv5S6m2xqySTnDxTs95k79LlKGoNLWNfok3suduecIFLnU7yKl3ouPkvuDk h5ebN4MbCqoKh/XtuPZkJi++tX3S11Cyhq+A9mKP9nPmfRKStfDmJSJMGbm2nBslJ+2m sDYQ== X-Gm-Message-State: APjAAAXOeCYU7tvrCV4MJ4SkToOKrTnt2srhpylZlQqM3vAhB/Wwa7S5 De3V4Q6gG/g2p9wKo2jnK2E= X-Google-Smtp-Source: APXvYqzHPw83Dakrgzt+aKPhIRb09VhGeDOYExNWEyT2uAWCali5wADUKo5ovo5XKlN72XYWqMv9fw== X-Received: by 2002:a19:7916:: with SMTP id u22mr354207lfc.144.1553129961191; Wed, 20 Mar 2019 17:59:21 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id u18sm578674ljd.77.2019.03.20.17.59.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Mar 2019 17:59:20 -0700 (PDT) In-Reply-To: <87lg192omi.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156556 Archived-At: On 20.03.2019 23:59, Juri Linkov wrote: > Do you think other commands that use xref-push-marker-stack > won't need setting the mark? Like I said, they probably already do. And this is a matter of a function changing into its related data structure. If we're going to make xref-push-marker-stack a single-stop-to-modify-all-stacks, that should be discussed first. Like I said, I don't have a lot of clarity about how and why people use the global/local marker stacks. >> (defun xref--show-xrefs (xrefs display-action &optional always-show-list) >> + (push-mark nil t) > > push-mark is usually called closer to the end of the command. You mean text-wise? I don't think it will make any practical difference in this case. >> (cond >> ((and (not (cdr xrefs)) (not always-show-list)) >> (xref-push-marker-stack) > > Some commands like e.g. ‘goto-line’ use such idiom: > > (or (region-active-p) (push-mark)) Sure, fine by me. We'll still want to call xref-push-marker-stack unconditionally, though.