From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 34908@debbugs.gnu.org, "joão távora" <joaotavora@gmail.com>
Subject: bug#34908: Push mark in xref-push-marker-stack
Date: Thu, 21 Mar 2019 02:59:18 +0200 [thread overview]
Message-ID: <789f35b5-7a33-286c-72ab-a9ebbf13d254@yandex.ru> (raw)
In-Reply-To: <87lg192omi.fsf@mail.linkov.net>
On 20.03.2019 23:59, Juri Linkov wrote:
> Do you think other commands that use xref-push-marker-stack
> won't need setting the mark?
Like I said, they probably already do. And this is a matter of a
function changing into its related data structure.
If we're going to make xref-push-marker-stack a
single-stop-to-modify-all-stacks, that should be discussed first. Like I
said, I don't have a lot of clarity about how and why people use the
global/local marker stacks.
>> (defun xref--show-xrefs (xrefs display-action &optional always-show-list)
>> + (push-mark nil t)
>
> push-mark is usually called closer to the end of the command.
You mean text-wise? I don't think it will make any practical difference
in this case.
>> (cond
>> ((and (not (cdr xrefs)) (not always-show-list))
>> (xref-push-marker-stack)
>
> Some commands like e.g. ‘goto-line’ use such idiom:
>
> (or (region-active-p) (push-mark))
Sure, fine by me.
We'll still want to call xref-push-marker-stack unconditionally, though.
next prev parent reply other threads:[~2019-03-21 0:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 21:12 bug#34908: Push mark in xref-push-marker-stack Juri Linkov
2019-03-18 21:50 ` João Távora
2019-03-18 23:14 ` Dmitry Gutov
2019-03-19 21:02 ` Juri Linkov
2019-03-20 1:47 ` Dmitry Gutov
2019-03-20 21:59 ` Juri Linkov
2019-03-21 0:59 ` Dmitry Gutov [this message]
2019-03-19 6:16 ` Eli Zaretskii
2019-03-19 11:57 ` Dmitry Gutov
2019-03-19 20:59 ` Juri Linkov
2019-03-20 5:59 ` Eli Zaretskii
2019-03-20 21:49 ` Juri Linkov
2019-03-21 3:35 ` Eli Zaretskii
2019-03-24 21:20 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=789f35b5-7a33-286c-72ab-a9ebbf13d254@yandex.ru \
--to=dgutov@yandex.ru \
--cc=34908@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.