From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#24206: 25.1; Curly quotes generate invalid strings, leading to a segfault Date: Sun, 14 Aug 2016 18:12:25 -0700 Organization: UCLA Computer Science Department Message-ID: <78989077-be2e-1618-0ec7-a543b75442ca@cs.ucla.edu> References: <83y43zfeqg.fsf@gnu.org> <1e16ff28-953a-9081-d9be-dc14b3e3e6ea@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1471223603 30522 195.159.176.226 (15 Aug 2016 01:13:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 15 Aug 2016 01:13:23 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 Cc: p.stephani2@gmail.com, johnw@gnu.org, nicolas@petton.fr, 24206@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 15 03:13:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZ6Sr-0007dG-P6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Aug 2016 03:13:17 +0200 Original-Received: from localhost ([::1]:34520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZ6So-0003r7-PW for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Aug 2016 21:13:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZ6Si-0003qk-06 for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 21:13:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZ6Sc-0006ef-TJ for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 21:13:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZ6Sc-0006ea-Q3 for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 21:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bZ6Sc-0001q0-FA for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2016 21:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2016 01:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24206-submit@debbugs.gnu.org id=B24206.14712235587030 (code B ref 24206); Mon, 15 Aug 2016 01:13:02 +0000 Original-Received: (at 24206) by debbugs.gnu.org; 15 Aug 2016 01:12:38 +0000 Original-Received: from localhost ([127.0.0.1]:57718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZ6SE-0001pK-5j for submit@debbugs.gnu.org; Sun, 14 Aug 2016 21:12:38 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZ6SC-0001p5-FW for 24206@debbugs.gnu.org; Sun, 14 Aug 2016 21:12:37 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8D7781611D9; Sun, 14 Aug 2016 18:12:30 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id nh3VVk8cia3Y; Sun, 14 Aug 2016 18:12:29 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 744E71611DF; Sun, 14 Aug 2016 18:12:29 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qILrkojYGw2O; Sun, 14 Aug 2016 18:12:29 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 503FC1611D9; Sun, 14 Aug 2016 18:12:29 -0700 (PDT) In-Reply-To: <1e16ff28-953a-9081-d9be-dc14b3e3e6ea@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122223 Archived-At: Paul Eggert wrote: > On 08/14/2016 12:21 PM, Eli Zaretskii wrote: >> Paul, would you agree with the following alternative patch for the >> release branch? > > Sure, that patch should also prevent crash that initiated this bug report > (though it does not fix the problem in general). Please mark it with "Do not > merge to master". > Whoops, I spoke too soon. Although your patch would prevent the crash, it has the unfortunate side effect of almost always disabling text-quoting-style, as the input to substitute-command-keys is normally not multibyte. So we really need some other fix, such as the one in .