From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59756: [PATCH] Use file-name-nondirectory to determine project-name Date: Fri, 2 Dec 2022 16:37:26 +0200 Message-ID: <786fefbb-d637-1580-dfbe-0b14f2aea6e9@yandex.ru> References: <831qpigrcl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24336"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 59756@debbugs.gnu.org To: Eli Zaretskii , Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 15:38:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p17BH-0006CC-5G for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 15:38:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p17Ax-0001Iv-Mr; Fri, 02 Dec 2022 09:38:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p17Aw-0001IY-5G for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 09:38:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p17Av-0004mL-SJ for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 09:38:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p17Av-00068p-Np for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 09:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 14:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59756 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59756-submit@debbugs.gnu.org id=B59756.166999185623583 (code B ref 59756); Fri, 02 Dec 2022 14:38:01 +0000 Original-Received: (at 59756) by debbugs.gnu.org; 2 Dec 2022 14:37:36 +0000 Original-Received: from localhost ([127.0.0.1]:47084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p17AV-00068J-RA for submit@debbugs.gnu.org; Fri, 02 Dec 2022 09:37:36 -0500 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:40583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p17AU-00068C-I7 for 59756@debbugs.gnu.org; Fri, 02 Dec 2022 09:37:35 -0500 Original-Received: by mail-wm1-f49.google.com with SMTP id v124-20020a1cac82000000b003cf7a4ea2caso6587255wme.5 for <59756@debbugs.gnu.org>; Fri, 02 Dec 2022 06:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=ujVk5O3sGFhl+ZSDbH84jSIU9fxfax1KDL5V00EZ1VI=; b=WKY32ImJVq6qNub5S3Qu0FYfbQ59M5ol+aUfbdpBCuqcLLMQYgHc/Y/5Xz0WhOwy3Y 83d488BWJiTcsfdhBWQ56eWaf3Xqaa203ZDlBlh1L6qLG73tUuDi17XSCn/mgBkZ3wcO 4mG7/aTAfa1SrzLIjAOFkZ41ZCzsSjskqH+0v9uzagp1hniRoj3QxS+t470GzI98SeXE 8CxfZmW9uxrmffxECYneoIx+ma9oujvqD3QNZK+iihE2qQtUZnbYuPLIbcGpAdn1wYzr jVH6nI57X3HnrJMMYqKOsRSxfkD0awuDW5DVTIWtQYpf1BEtSCjoMSCFWSQeHb37fDt4 e84A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ujVk5O3sGFhl+ZSDbH84jSIU9fxfax1KDL5V00EZ1VI=; b=LU9Z9LGQy5J4J7KIZ1cSDVKr+AyZY8RPlkPHUjP3qmEvXpSm6ToX+8o/FNpXnuzZD4 ts25KVbxNHtpKPhohC8JUVhIoBbCrorLj3Gda3qI2T2hNKUT06BjR5LojWNB++9nCV2N eCjqHYb7PQXdnyvjXxSZvtkgTDKmimG74A0GgRE3qs0gbiMEjklzmf0kzeD04j8kd20n Z0UTRYfDI6Mtkv0u/WMmJ35EZYqA3JhxBMOVTbLeRgHEmJrTaJKds3Mn5s79mxx9H1aI PpWaMlrni+xoKogjCZLD5AOstxEUx3G0Ge3WOJ/L26svylzib83CDNLfkyNoqRZRdX7j BTbw== X-Gm-Message-State: ANoB5pmVy73o57eODyDSTa244r0rRASuUhbQ4MXLWa2je0pL4eFUgSB3 RziC/xOiuc5ZmwXJtbDsZFA= X-Google-Smtp-Source: AA0mqf41eGVWJ5xxTsBVQD/XVmOe/qh8q3X2gf1M7w+mFMdBlWercNHQvGTWKbo9u7T2YzrGVjHP4Q== X-Received: by 2002:a05:600c:4f55:b0:3cf:729b:d4b4 with SMTP id m21-20020a05600c4f5500b003cf729bd4b4mr46825253wmq.48.1669991848460; Fri, 02 Dec 2022 06:37:28 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c14-20020a05600c0a4e00b003cffd3c3d6csm8681967wmq.12.2022.12.02.06.37.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 06:37:27 -0800 (PST) Content-Language: en-US In-Reply-To: <831qpigrcl.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249752 Archived-At: On 02/12/2022 10:08, Eli Zaretskii wrote: >> Cc: dgutov@yandex.ru >> Date: Fri, 02 Dec 2022 03:34:30 +0000 >> From: Randy Taylor >> >> If a project is named something like ".emacs.d", file-name-base will return ".emacs" instead of ".emacs.d" as >> expected (or at least as I expect it). >> >> Therefore, we use file-name-nondirectory instead. > > Why do we want to support such project names? The bug's description is not very good. The goal of the code in question is to produce an automatic version of the project name from its root directory, allowing individual project backends to override that logic. This fix is an update for the same (logic to produce the default name), restoring what I'm sure was the original intent. The directories just don't often have extensions, so it passed by the initial testing. > I could also name my project /foo/bar/baz, and defeat file-name-nondirectory > as well. Where does it end? This is not about the user naming a project something. ELISP> (file-name-nondirectory (directory-file-name "/foo/bar/baz/")) "baz" This is correct. This custom name (e.g. set through project-vc-name) does not pass through this conversion. You can use whatever special characters you want, why not? Newlines might break some UI, but if the user wants that...