From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Fri, 30 Dec 2022 15:39:20 +0100 Message-ID: <785dab0b-1b9b-6479-9e17-25effdff2ba2@secure.kjonigsen.net> References: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> <83lemp717m.fsf@gnu.org> <4bb171b5-71d8-d265-0bf6-d688b5146603@secure.kjonigsen.net> <838rip6kq3.fsf@gnu.org> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18412"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Cc: 60376@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no To: Eli Zaretskii , jostein@kjonigsen.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 30 15:40:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBGYV-0004Y0-8F for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Dec 2022 15:40:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBGYI-0002r2-Oi; Fri, 30 Dec 2022 09:40:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBGYF-0002q8-J5 for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 09:40:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBGYE-0004nm-Rk for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 09:40:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBGYE-0006N2-Cq for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 09:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Dec 2022 14:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.167241117224440 (code B ref 60376); Fri, 30 Dec 2022 14:40:02 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 30 Dec 2022 14:39:32 +0000 Original-Received: from localhost ([127.0.0.1]:33802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGXj-0006M8-SE for submit@debbugs.gnu.org; Fri, 30 Dec 2022 09:39:32 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGXh-0006Lq-9j for 60376@debbugs.gnu.org; Fri, 30 Dec 2022 09:39:29 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CB9A05C00D6; Fri, 30 Dec 2022 09:39:23 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 30 Dec 2022 09:39:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1672411163; x=1672497563; bh=qb N2Rk2bYuvb/Q1u2IBQbWXdKqLUNoBl+AKJQK6HRRE=; b=T2QKnWVAeEUjI0sR0w FFT09qQfg+0LC0RuTwKmzQJIrazZv+S+2BnIgBlnDSesq5U7Vt4VXWOaD7zUqCRU aDnWDWm+fp0TMJ+FKi4Zr5v80m3cYVrzWEtR7PgUBAQbvyBLNgRjRXFKws4Q1flD jaIZ8vSs1W7GUwPcCcpgTCYqOJsgABl70bMTGiOqQ3CAEpl6n7zTpJtw32geW/CC /k+3EiMOqYDnxWTjxV1hXJryTGrct12hnLLTRR44VCBicLw/BRfNogYl3+Oq4POI 0ozLo3XH/J2vkLt7J9SOm8SHUDxOdE8YytQd/W1suVXr+9+ZossRdR6z2OvHQjWf l4vw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1672411163; x=1672497563; bh=qbN2Rk2bYuvb/Q1u2IBQbWXdKqLUNoBl+AK JQK6HRRE=; b=StHa66ehdDlhhykFa06oK8bIoGF+mIRyMaz/MRUpsPhvB4IkOq9 VXAdDqZ/hi3HY83tMNapb7yvfcKsZLipCPg+YHOPaVJiP6BDVPsjwIHbsLcM5SFo PVtqKT1RbPERCgdFrtKbyS5utdeE1FmxGyOSyhmdIneIGOxYoHJJy3FYUkGWi+SP hl0S2zlKx1xReN+iEaNO+38/wLuHz7bsNlf1EoqavcFrfp02rpNxJXN8rj126h9q SS3HTbMjpog6htFbl7NaP7a2cshU0AAWQV4nEJqey/mFN9Nmgq+QKATUxRxhsqgQ IsP/O1QYznj0lUENMOL9LqbRJw9fzhiiilQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrieeigdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfghruffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpefhgeevvefhfeeffedtvdfhvdei ieffheeiheegheegtddtkeevffelteetgedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhn ihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Dec 2022 09:39:22 -0500 (EST) Content-Language: en-GB, nb-NO In-Reply-To: <838rip6kq3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252123 Archived-At: On 30.12.2022 15:15, Eli Zaretskii wrote: >> Ok. That's unfortunate timing. >> To be clear, I think it's absolutely realistic to get csharp-ts-mode to >> adhere to some of the guidelines outlined in the >> tree-sitter-standardization thread. >> >> But it's completely unrealistic (at least on my part) to get any >> well-crafted and well-tested changes into csharp-ts-mode until after >> new-years. > If you can come up with a 85% correct code soon, and leave the rest > for bug-fixing, that's also acceptable. > > Otherwise, please understand my POV: we do want to release Emacs 29 > soon. The tree-sitter related features already got a full month of > slack, whereby new features were acceptable on the release branch. If > we keep delaying the freeze, we will not release Emacs 29 any time > soon. You have all been here for the past month, and I announced the > rules loud and clear, so if some modes are still not up to speed with > the latest treesit.el changes, then it's too bad, but we will have to > wait for Emacs 30 with those. I'm sorry, but we do need to draw the > line in the sand at some point: people are waiting for Emacs 29, and > we cannot disappoint them. I completely understand. I've left some thoughts about the standardization-process -in general- in the Emacs-devel thread, on how we should "cope" with exactly that situation. To be clear: I think csharp-ts-mode works well beyond 85% (it's what I use as my daily driver), but the syntax-highlighting at level 3 may be more excessive than some people (like Stefan) prefer. If we instead for these "major" changes suggested by Yuan, instead aim for just moving some "smaller" implementation-detail (function-invocations and property-highlighting) to level 4, I think we she be able to get something which is mostly what Stefan would expect and prefer, and it would be a much smaller change. Then we can take a look at those bigger changes (standardized features, enabling/disabling them individually, as end-users, etc) for Emacs-30. I think that's a more realistic plan. Does that sound OK? -- Jostein