From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#9919: 24.0.91; font-lock broken in dired Date: Mon, 9 Jan 2012 16:04:19 -0800 Message-ID: <7828076964A745E39311AEB941AD52F0@us.oracle.com> References: <1161A09A8D6E494CBF91D53B99D5FBC2@us.oracle.com><86k47fuzce.fsf@googlemail.com><01BD44CE3569404796A5C8252DDA7BDB@us.oracle.com><7F9343C4FA564C29BE7E8576E5A25183@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1326153894 12083 80.91.229.12 (10 Jan 2012 00:04:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 10 Jan 2012 00:04:54 +0000 (UTC) Cc: 9919@debbugs.gnu.org To: "'Stefan Monnier'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 10 01:04:50 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RkPCs-0004bp-5R for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Jan 2012 01:04:50 +0100 Original-Received: from localhost ([::1]:35294 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkPCr-0000mq-ON for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Jan 2012 19:04:49 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:47195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkPCp-0000ml-L2 for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2012 19:04:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkPCo-0007WZ-GV for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2012 19:04:47 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkPCo-0007WV-CS for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2012 19:04:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RkPD4-0006GK-Ao for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2012 19:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Jan 2012 00:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9919 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9919-submit@debbugs.gnu.org id=B9919.132615388924051 (code B ref 9919); Tue, 10 Jan 2012 00:05:02 +0000 Original-Received: (at 9919) by debbugs.gnu.org; 10 Jan 2012 00:04:49 +0000 Original-Received: from localhost ([127.0.0.1]:51459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RkPCq-0006Fr-IE for submit@debbugs.gnu.org; Mon, 09 Jan 2012 19:04:49 -0500 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:34952) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RkPCo-0006Fe-D6 for 9919@debbugs.gnu.org; Mon, 09 Jan 2012 19:04:47 -0500 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id q0A04Mvq009559 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Jan 2012 00:04:23 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q0A04Llt027388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 10 Jan 2012 00:04:22 GMT Original-Received: from abhmt110.oracle.com (abhmt110.oracle.com [141.146.116.62]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q0A04LXA021260; Mon, 9 Jan 2012 18:04:21 -0600 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 09 Jan 2012 16:04:20 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AczPHzIyWtXJZjBJSo2C7y/C+YDf7QAB0Ljg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090209.4F0B8088.0022,ss=1,re=0.000,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55593 Archived-At: > > (add-hook > > 'dired-mode-hook > > (lambda () > > (set (make-local-variable 'font-lock-defaults) > > (cons '(dired-font-lock-keywords > > diredp-font-lock-keywords-1) > > (cdr font-lock-defaults))) > > Now after running the above code, the user adds > (add-hook 'dired-mode-hook (lambda () (font-lock-mode 1))) > and suddenly the bug shows up even in Emacs-23. OK, so Emacs broke it in 23 instead of 24. ;-) That does not happen in Emacs 20-22 AFAICT. What's the gotcha for Emacs 20-22? What does a user need to do in Emacs 20-22 to show that this code won't DTRT? Let me put it this way: I've never seen the problem in Emacs 20-22, and I've never received a report from anyone mentioning such a problem with that code. Did you receive any Emacs 20-22 bug reports, for example, from users who, like me, did not understand that such problematic behavior was inherent? Not that such reports would have corresponded to real bugs, from what you say, but presumably there would have been at least someone who was bitten by what you say has always been an inherent gotcha/problem. I'm just curious why this is manifested in 24 without doing anything, and in 23 if you do as you note above, but not at all (AFAICT) in 20-22. > > What's the cause of this change/regression? > > Nothing very deep. The moment when font-lock-mode gets enabled > has changed. I'm not convinced the new time is really much > better, but I'm not convinced the old time was better either. Was that change made in Emacs 23 or 24? See my question above - just trying to understand the differences between (a) 20-22, (b) 23, and (c) 24. > Basically it used to be enabled after running the mode hook, > which made it difficult to disable font-lock-mode via a > mode-hook check, wherea now it gets enabled before, so you can just do > > (add-hook 'dired-mode-hook (lambda () (if foo (font-lock-mode -1)))) I see. Thanks for the explanation. Makes sense.