From: Dmitry Gutov <dmitry@gutov.dev>
To: Yuan Fu <casouri@gmail.com>, Felix <felix.dick@web.de>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Tree-sitter navigation time grows as sqrt(line-number)
Date: Fri, 18 Aug 2023 16:29:21 +0300 [thread overview]
Message-ID: <7822ea29-10c1-fc3a-fe68-30011ae98db4@gutov.dev> (raw)
In-Reply-To: <3DA8CA36-7B5F-4992-BEDB-8D5699A47ABB@gmail.com>
On 18/08/2023 05:49, Yuan Fu wrote:
> So I guess the cursor stuff caused the crash.
Not at all, the crash was entirely the fault of v1 of my patch (where I
didn't check whether the returned node is_null.
> But we shouldn’t fix it by using tree_sitter_node_parent, we
purposefully replaced it using the cursor API, see bug#60054.
Yeah, I've found this thread a little after posting the v2 patch.
Even so, trying it out might be useful to see whether the built-in
ts_node_parent is faster in some specific usage scenarios than what we
currently have to use. If that is found to be the case, we'll know the
potential direction for improvement, at least.
next prev parent reply other threads:[~2023-08-18 13:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87v8ddsqwe.fsf@web.de>
2023-08-17 14:25 ` Tree-sitter navigation time grows as sqrt(line-number) Dmitry Gutov
2023-08-17 14:36 ` Dmitry Gutov
2023-08-17 15:01 ` Dmitry Gutov
2023-08-17 15:15 ` Felix
2023-08-18 2:49 ` Yuan Fu
2023-08-18 13:29 ` Dmitry Gutov [this message]
2023-08-17 4:01 JD Smith
2023-08-17 10:56 ` Dmitry Gutov
2023-08-17 11:41 ` Eli Zaretskii
2023-08-17 11:51 ` tomas
2023-08-17 12:21 ` JD Smith
2023-08-17 12:34 ` Dmitry Gutov
2023-08-17 13:19 ` Dmitry Gutov
2023-08-19 14:24 ` JD Smith
2023-08-19 22:16 ` Yuan Fu
2023-08-20 0:18 ` JD Smith
2023-08-20 0:39 ` Dmitry Gutov
2023-08-20 2:01 ` Yuan Fu
2023-08-20 12:40 ` JD Smith
2023-08-20 20:26 ` Dmitry Gutov
2023-08-22 1:41 ` Yuan Fu
2023-08-22 21:07 ` JD Smith
2023-08-31 4:26 ` Yuan Fu
2023-08-31 6:03 ` Eli Zaretskii
2023-08-31 11:04 ` Dmitry Gutov
2023-08-31 11:42 ` Po Lu
2023-08-31 17:32 ` Dmitry Gutov
2023-08-31 12:51 ` Eli Zaretskii
2023-08-31 13:58 ` JD Smith
2023-08-31 17:49 ` Dmitry Gutov
2023-08-31 19:03 ` Yuan Fu
2023-08-31 19:06 ` Eli Zaretskii
2023-08-31 20:24 ` Stefan Kangas
2023-09-01 5:33 ` Eli Zaretskii
2023-08-20 6:18 ` Eli Zaretskii
2023-08-18 3:00 ` Yuan Fu
2023-08-18 4:19 ` JD Smith
2023-08-18 5:20 ` Yuan Fu
2023-08-18 13:21 ` Dmitry Gutov
2023-08-18 13:39 ` JD Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7822ea29-10c1-fc3a-fe68-30011ae98db4@gutov.dev \
--to=dmitry@gutov.dev \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=felix.dick@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.