From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Date: Mon, 6 Feb 2023 18:05:52 +0100 Message-ID: <7802fc0d-3abc-8905-411b-4ada721e8013@secure.kjonigsen.net> References: <792EC2CE-006B-42F1-81C2-453E71C2173C@gmail.com> <12a97d26-90cc-4a25-61a5-5aff33915610@secure.kjonigsen.net> <2F86FB50-87F7-432D-B87A-1738056907AB@gmail.com> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20525"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Cc: casouri@gmail.com, 61104@debbugs.gnu.org, Theodor Thornhill , Eli Zaretskii To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , jostein@kjonigsen.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 06 18:07:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pP4xV-00055x-3V for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Feb 2023 18:07:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP4xM-0007mL-Kj; Mon, 06 Feb 2023 12:07:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP4xL-0007fv-3e for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 12:07:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP4xK-0008Tu-R9 for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 12:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pP4xK-0006H8-En for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 12:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs Original-Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167570316424029 (code B ref 61104); Mon, 06 Feb 2023 17:07:02 +0000 Original-Received: (at 61104) by debbugs.gnu.org; 6 Feb 2023 17:06:04 +0000 Original-Received: from localhost ([127.0.0.1]:49762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP4wO-0006FV-BP for submit@debbugs.gnu.org; Mon, 06 Feb 2023 12:06:04 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP4wL-0006Eu-Pk for 61104@debbugs.gnu.org; Mon, 06 Feb 2023 12:06:02 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B74E65C00CD; Mon, 6 Feb 2023 12:05:55 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 06 Feb 2023 12:05:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm2; t=1675703155; x=1675789555; bh=/3 /6C+pZUGu2sI7L4bvFpxFKSRXo8AWdQcHvMRX0BFI=; b=FtdQbPZjTdAwfPYQwt L0AbA4F7DPZQ6ZIwfPE06a55JjM2CRtQ7eN2k1D4ItB1IM16+h5wL1wFvODVMoI7 jHTfLCQXRUVehKlfUmJqJUnTU1rKyhEv6oISHtyvRoqERBw2k1L1Yjsr4tVZwo0R yNLcrVKVkQzMhCsLer29uF5H3NMJKLjXorXFBLbxqtbrfM76Gh4g5aC+EUgFNkFa 2udHvhr1xTtV1zimLl+LJvgJeDEha4bk1QG/1QszqnagFPAP0KeGOxO3Hg58sXDJ XK8xk8/8l3KHQwKGHMBGynh73nQBAmNUk3RueGhNQmOA+SAWI3FFdyuf6PO8MslP sRCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1675703155; x=1675789555; bh=/3/6C+pZUGu2sI7L4bvFpxFKSRXo8AWdQcH vMRX0BFI=; b=iSYhYK6CGbaDWHAOcRfr2gW+IeFDeh97nTQBWKt2ASZ6Zko8vzQ iO0uGQlQNS95rn1pLkvyRu2R5whlxezN24eV03P5euULiG5mHOCfeQs6QiuvEAn4 p0CxdP6pLpCb7SWrvxduaBZj7XXTWgQhaVNJ6gHHJ1EUcQsYWI0ib5QZbd71hdev 0vMVJybTVPSVvVA38mRfeBLh1jbznUo3SyIbeFCRHPiIfDW+zyj9yKVEPXqUZshG 8Ii8sgaWGTybGwKMvdBGT72w7JpNIMDosMVA+Ztmu/0hSIh/0RImcd+hXNYLhLnb TcQFL3oFNlJAo2AAyo+o6wtUXVfY2h6c4ug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegiedgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfrhfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomheplfho shhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnheptdeftdektdffueekvddvvdek ueevuddviedtffffgffggeeltdekhefgtdejkeevnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhho nhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Feb 2023 12:05:54 -0500 (EST) Content-Language: en-GB, nb-NO In-Reply-To: <2F86FB50-87F7-432D-B87A-1738056907AB@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254982 Archived-At: On 2/6/23 12:19, Mattias Engdegård wrote: > Thank you! I translated the regexps to rx (which I personally find > more maintainable and has plenty of precedence in this context) and > tightened them up further. They are now anchored at beginning-of-line > again, and file names cannot start with whitespace (for disambiguation > and speed). Thanks. These are all good changes. > I also removed the part that matches the actual message text since it isn't needed, and it would highlight (with an underline in the standard theme) the whole text which is a bit ungainly to read. If the message is multi-line, which earlier examples in this discussions indicated might be the case, then only the first would be highlighted this way which wasn't ideal either. Seconded. No issues with that either. > Does tsc distinguish between warnings, errors, and 'informational' messages (such as locations of interest that are not errors in their own right)? The examples you supplied all had the word "error" in a prominent place. I don't think so. There are code-analysis warnings which seems to be provided to your editor of choice through LSP. These can be made into a compilation-error with the appropriate config-flag, but I can't out of the blue find any "middle ground" where they are emitted compile-time as warnings. Someone please correct me if I'm wrong. > It would be possible to join the two tsc rules into a single one which would be slightly faster, but having them separate could also be an advantage since it would allow for them to be disabled individually in case of clashes. To me that sounds like an optimization going one step too far. It will result in a more complex expression, which is harder to work with/maintain, and might also be more computationally expensive due to back-tracking complexity. I personally think that having 2 self-documented expressions side by side works better, but I'm no authority on compilation-mode and performance :) > Patch attached, please tell me what you think. I've tested that patch myself, and from what I can tell, it still works just fine :) -- Jostein