From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63939: 28.2; xref-find-references-and-replace (xref-1.6.3) Date: Sat, 12 Aug 2023 03:39:56 +0300 Message-ID: <77b9fdbb-2049-f6b1-5c69-69caac8fd43d@gutov.dev> References: <87v8g02xd4.fsf@gmail.com> <734ca82a-2e29-33a5-acac-811f51dd58bc@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38237"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Aidan Hall , 63939-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 12 02:41:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUch1-0009jA-UC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Aug 2023 02:41:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUcgi-000724-Fr; Fri, 11 Aug 2023 20:41:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUcgg-00071H-PX for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 20:41:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUcgg-0000og-Gf for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 20:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUcgg-0006dT-CJ for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 20:41:02 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Aug 2023 00:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63939 X-GNU-PR-Package: emacs Mail-Followup-To: 63939@debbugs.gnu.org, dmitry@gutov.dev, aidan.hall202@gmail.com Original-Received: via spool by 63939-done@debbugs.gnu.org id=D63939.169180080925432 (code D ref 63939); Sat, 12 Aug 2023 00:41:02 +0000 Original-Received: (at 63939-done) by debbugs.gnu.org; 12 Aug 2023 00:40:09 +0000 Original-Received: from localhost ([127.0.0.1]:48279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUcfo-0006c8-TK for submit@debbugs.gnu.org; Fri, 11 Aug 2023 20:40:09 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:38891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUcfl-0006bU-9N for 63939-done@debbugs.gnu.org; Fri, 11 Aug 2023 20:40:06 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A13703200925; Fri, 11 Aug 2023 20:39:59 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 11 Aug 2023 20:39:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1691800799; x=1691887199; bh=ULG6ziNsbRx34qQJvz78XRllVi8QR2XYC0B lQUSB4S8=; b=XYEj6gAWjzroaA1+tm06hwLlKIeWNAlgYY0IBo/L+9EVtWr0A8/ 13y5GXUtEQwya/2W3hIBot27AVpFDhykqftP9kl0U8fRsXZOKCoicfJ/bsCc75Qe 4+8WZAvfOfClolh/3glRq3KNJh1DNdeuI+sGjCaKpmDrJ1/sTd0/NHtk78BF17zk tsc0BoBRDwGiqPvPT0sQZWD5L4vRAKsDQ9/7hoCr/nOBJ1ztVZh/vA30Ds3irNRl edlUy8RrI5n4kJjCS4vSGyG6PzVwfR1IfbnRHmLQPUIY5StxoLlE6KZxB0D62Wb1 27K4AmaU7GI5iPWRrYVL+pChi5EbCaVWNtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1691800799; x= 1691887199; bh=ULG6ziNsbRx34qQJvz78XRllVi8QR2XYC0BlQUSB4S8=; b=I zOglw7LzETbHU5pocnRiG+hwE8AiGo3NXGwSWoEcxaKGFVkYr23Bq5tI/jFvo/Zo pW6/zppNMw0ejhXnojeEKKVkvMhhjBuNsr5WV4inECMjPtYzTt0fo+jOiirPL/7U UtT6qVdiJ+AHhl5vMcpXMlvTd7U1PoJaPLWTTf9WKNzo7bBglLcHqz/HI3NKsoPv q8QrWqJVQLuznQ8MdI9tvkAdEFQIhOC6m/IblMm1psdFOHejaPp7e0I6iqyKx+ho VEGlvZj693LG/Ib6NqyxMzLZbznZN3KhP5HcA1cKEZd6aLkYKb4yYiQKqGDsUk5u uTtu1TziMqLyYs4vqKpOQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrleelgdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuhffvfhgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhithhr hicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvg hrnhepteeugffffefhjeelleejgfevhedtfeeigeffheettefhiedtveejgffhueegkeff necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmih htrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Aug 2023 20:39:57 -0400 (EDT) Content-Language: en-US In-Reply-To: <734ca82a-2e29-33a5-acac-811f51dd58bc@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267237 Archived-At: On 20/06/2023 05:37, Dmitry Gutov wrote: > On 06/06/2023 22:40, Aidan Hall wrote: >> xref-find-references-and-replace uses query-replace-read-args to read >> the identifier to replace, but I think it would make more sense for it >> to use xref--read-identifier for consistency with the other xref >> commands. > > Does this help? > > diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el > index 643eea1b0a3..3f75f8d7132 100644 > --- a/lisp/progmodes/xref.el > +++ b/lisp/progmodes/xref.el > @@ -1613,7 +1613,8 @@ xref-find-references >  (defun xref-find-references-and-replace (from to) >    "Replace all references to identifier FROM with TO." >    (interactive > -   (let* ((query-replace-read-from-default 'find-tag-default) > +   (let* ((query-replace-read-from-default > +           (lambda () (xref-backend-identifier-at-point > (xref-find-backend)))) >            (common >             (query-replace-read-args "Query replace identifier" nil))) >       (list (nth 0 common) (nth 1 common)))) Now pushed to master.