From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>, Wilhelm Kirschbaum <wkirschbaum@gmail.com>
Cc: 61996@debbugs.gnu.org, theo@thornhill.no, casouri@gmail.com
Subject: bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode
Date: Sat, 11 Mar 2023 16:16:24 +0200 [thread overview]
Message-ID: <77b6fddf-ee84-9a3e-e08e-768bc05359b7@yandex.ru> (raw)
In-Reply-To: <83356by7fr.fsf@gnu.org>
On 11/03/2023 11:16, Eli Zaretskii wrote:
>> +(defun heex-ts-mode--forward-sexp (&optional arg)
>> + (interactive "^p")
> Why is a command an internal function? That is unusual, as commands
> are by definition public. It looks like you thought the double-hyphen
> "--" notation is a simple delimiter between the package-name part of
> the symbol name and the rest? If so, you were mistaken: the
> double-hyphen means this is an internal function/variable. Please
> review all your symbol names in this patch and rename as appropriate.
I'm guessing it was made interactive for debugging purposes.
But even that doesn't seem necessary: calling 'forward-sexp' through its
regular binding will invoke forward-sexp-function basically right away.
(treesit-forward-sexp doesn't need to be interactive either.)
next prev parent reply other threads:[~2023-03-11 14:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 7:04 bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode Wilhelm Kirschbaum
2023-03-06 11:59 ` Eli Zaretskii
2023-03-06 17:23 ` Wilhelm Kirschbaum
2023-03-06 18:36 ` Eli Zaretskii
2023-03-06 19:24 ` Wilhelm Kirschbaum
2023-03-06 20:14 ` Eli Zaretskii
2023-03-11 9:16 ` Eli Zaretskii
2023-03-11 14:16 ` Dmitry Gutov [this message]
2023-03-11 18:27 ` Wilhelm Kirschbaum
2023-03-11 18:01 ` Wilhelm Kirschbaum
2023-03-12 9:00 ` Eli Zaretskii
2023-03-12 9:54 ` Wilhelm Kirschbaum
2023-03-12 11:37 ` Eli Zaretskii
2023-03-12 12:23 ` Wilhelm Kirschbaum
2023-03-12 12:32 ` Wilhelm Kirschbaum
2023-03-12 15:14 ` Wilhelm Kirschbaum
2023-03-12 15:46 ` Eli Zaretskii
2023-03-12 18:02 ` Wilhelm Kirschbaum
2023-03-06 16:41 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77b6fddf-ee84-9a3e-e08e-768bc05359b7@yandex.ru \
--to=dgutov@yandex.ru \
--cc=61996@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=theo@thornhill.no \
--cc=wkirschbaum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.