From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: Recent change to describe-variable Date: Mon, 4 Apr 2011 06:03:09 -0700 Message-ID: <77BECCED88B440C6A9F9C01692854B66@us.oracle.com> References: <874o6gur58.fsf@stupidchicken.com> <87r59ibbff.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1301923025 21356 80.91.229.12 (4 Apr 2011 13:17:05 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2011 13:17:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: "'Juanma Barranquero'" , "'Ted Zlatanov'" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 04 15:17:01 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q6jeM-0005RG-Jv for ged-emacs-devel@m.gmane.org; Mon, 04 Apr 2011 15:16:59 +0200 Original-Received: from localhost ([127.0.0.1]:40444 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6jRl-0001hN-Lp for ged-emacs-devel@m.gmane.org; Mon, 04 Apr 2011 09:03:57 -0400 Original-Received: from [140.186.70.92] (port=57927 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6jRY-0001VB-QP for emacs-devel@gnu.org; Mon, 04 Apr 2011 09:03:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6jQu-0002Jn-QO for emacs-devel@gnu.org; Mon, 04 Apr 2011 09:03:05 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]:46834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6jQu-0002Jb-Kq for emacs-devel@gnu.org; Mon, 04 Apr 2011 09:03:04 -0400 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p34D2xE3020975 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 4 Apr 2011 13:03:02 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id p34D2wcC017967 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 4 Apr 2011 13:02:58 GMT Original-Received: from abhmt007.oracle.com (abhmt007.oracle.com [141.146.116.16]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p34D2vtF014747; Mon, 4 Apr 2011 08:02:58 -0500 Original-Received: from dradamslap1 (/10.159.34.132) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 04 Apr 2011 06:02:57 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 Thread-Index: Acvys6dLBnx6mvZSTdeqWEUX760PWAAEfcZQ X-Source-IP: acsmt356.oracle.com [141.146.40.156] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4D99C183.0016:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 148.87.113.121 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138113 Archived-At: > > So if `C-h v' AKA `describe-variable' is going to describe > > everything, it should at least filter out self-quoting :symbols > > At your request I installed a change to exclude :keywords Oh, are we now installing things at the request of one Emacs user/developer? Someone has an idea s?he thinks is good, so it's installed as part of Emacs? > but the lexbind-new merge overrode it. So if the current > predicate is removed it would be good to filter out keywords > again (though it makes sense to let pass keywords with a > docstring, which my original patch didn't). Keywords with a doc string and without. I agree with the post below by Stefan to the cited thread: if it has a doc string, include it. And even if it doesn't have a doc string, include it ("No documentation" is useful information.) j>> (defconst :mykeyword :mykeyword) j>> and even if you add a docstring to that, I'm not sure it is sensible j>> to show it as a completion of describe-variable... s> s> Actually, if it has a docstring, it definitely makes sense. And if it s> doesn't, then it's not that much of a problem to include those rare s> cases in the completion. It ain't broke. Please don't fix it. Let _users_ filter things as they like. And if some user wants a specialized "`my-describe-emacs-variable' or `my-describe-documented-variable' then s?he can define the command and post it to the wiki. It's not rare (or difficult) for a user to define a specialized `describe-*' command. Emacs doesn't need it. Especially as a replacement for `describe-variable'.