From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 7362554: Widen around c-font-lock-fontify-region. This fixes bug #38049. Date: Thu, 14 Nov 2019 21:58:24 +0200 Message-ID: <779ef173-2f78-8424-49bf-480629361a07@yandex.ru> References: <20191109144026.20810.76129@vcs0.savannah.gnu.org> <20191109144027.DDC3720927@vcs0.savannah.gnu.org> <38328d99-23c8-7ba7-a23d-e70ac0aab67a@yandex.ru> <20191111203445.GA5135@ACM> <7497e71d-bab6-fa04-bbc4-f52fadeda16d@yandex.ru> <20191113211936.GB4942@ACM> <6fc930a1-eb47-9e54-8752-8cf7ff041586@yandex.ru> <03042d05-2160-77c4-9abd-b0f13f638247@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="87059"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: Alan Mackenzie , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 14 21:00:17 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVLHs-000MQA-RG for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 21:00:17 +0100 Original-Received: from localhost ([::1]:33272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVLHr-0004US-2p for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 15:00:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35054) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVLGM-0003Gz-LB for emacs-devel@gnu.org; Thu, 14 Nov 2019 14:58:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVLGL-0003mP-Ne for emacs-devel@gnu.org; Thu, 14 Nov 2019 14:58:42 -0500 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:32867) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVLGL-0003lz-GZ for emacs-devel@gnu.org; Thu, 14 Nov 2019 14:58:41 -0500 Original-Received: by mail-wr1-x429.google.com with SMTP id w9so8095122wrr.0 for ; Thu, 14 Nov 2019 11:58:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Wu1btyruvnEA5EivGtRtWH48EpLxhZ5H/KVE8Q6I5MQ=; b=BY2uxdqCc8FChp+ui4L0NWNkGe99o8pJw1b2PF95PE/YXJFYfwQnrRmVUQd5hn71cj nU5tbBbrMCrPvZ5/CTD8KEjMwbjglvFI1sG/VEBBGrCdvofldwfPRs9empqLZGL4XUNR 7Y2FaDy132mjGLv32dG7OBZGNaFglddsojoel+J/uxBkX9+q+/2T3+4/V+2PTRAkzB5D gJ1qd+6K0jfBIn+TBBAlBF+OlXT0m5JARrwXXrNN1Eg0dfiI7ocQ8qYh0YUApsMu4uVE Lhdlxyj43pd7UiPT+EwxJ2vJZ9SEHIw8qo4tzUwrD3LV+a2Ob0CqOiXukeZ3tdvhDH3v nkUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Wu1btyruvnEA5EivGtRtWH48EpLxhZ5H/KVE8Q6I5MQ=; b=NkJBTSLrhAzJAd7NzXeDhtDpcW4unFQN2mqa1RBg6SWoUD/M5U5kJy82OGWZ278mZU JOulAndo/zXT44QbIztKswF0Td6C2/7xH+6aFWNoa8QFkTJzYmbRMt18HfWPKrK+C+Hc rnXUMJXZPcQ8LCtEZttffoSYghxubys7mRiojQFPwPkXXPjNQiczORW2WR6DbfBz5S/b Q7U++0hTA6+UEWR66wdbk5XosHEVq+Rgj7wwF4SfyatihvUdvY6YOfKVwSc0czlaAL9k uC7nLPyrIa/0JY6bkobPfHp4ZtMY4Iewp2r5IFAaIQvdOb3v+vDx0yCAbt77gZyd4gpi Nmcw== X-Gm-Message-State: APjAAAX3EO6ynI7oL+V7AWImKnX8YqzSnEFm6nhMc1tEREiyH6DCQMvv DELSQj+400usD7WXLPUQ24qUAgRkQRI= X-Google-Smtp-Source: APXvYqxonqnLhRfK+znK+hi9ThkT+JslS6bEDGRDbh0Rj4TQsNOCxnNYNbiOGk0XTKlaszF5F1/Xww== X-Received: by 2002:a5d:570a:: with SMTP id a10mr878104wrv.107.1573761519833; Thu, 14 Nov 2019 11:58:39 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id 11sm7898928wmb.34.2019.11.14.11.58.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 11:58:39 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::429 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242198 Archived-At: On 14.11.2019 16:55, Stefan Monnier wrote: > So, your earlier patch which added a call to > `font-lock-ensure` was "more or less right", except that it should have > used `jit-lock-ensure` (currently called `jit-lock-fontify-now`) Stefan, could you also clarify that? font-lock-ensure-function is set to jit-lock-fontify-now when jit-lock is in use. And when it's not, wouldn't it be better to fontify the region the "old" way instead of leaving it unfontified? Is that because font-lock-ensure calls font-lock-set-defaults?