From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#13687: /srv/bzr/emacs/trunk r111878: * lisp/replace.el(read-regexp): Let-bind `default' to the first Date: Sat, 9 Mar 2013 09:14:41 -0800 Message-ID: <778E2A4E7CBA425C994F7678C2E690CE@us.oracle.com> References: <877glsyecw.fsf@gmail.com> <87621cfhff.fsf@mail.jurta.org><87zjykygjk.fsf@mail.jurta.org> <87vc92gi37.fsf@gmail.com><1751CEB23B214A3AADCCFD9F007425DE@us.oracle.com><87li9xer9u.fsf@mail.jurta.org><8738w5n3rg.fsf@gmail.com> <87d2v9rmcl.fsf@gmail.com><87sj44o87c.fsf@gmail.com><365EC1D3D8334B83827CDD1691FDEBC7@us.oracle.com> <87vc90se5a.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1362849337 11126 80.91.229.3 (9 Mar 2013 17:15:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Mar 2013 17:15:37 +0000 (UTC) Cc: 13687@debbugs.gnu.org To: "'Jambunathan K'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 09 18:15:59 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UENNB-0001It-Vx for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Mar 2013 18:15:54 +0100 Original-Received: from localhost ([::1]:36682 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UENMp-0006r9-Vx for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Mar 2013 12:15:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UENMh-0006qn-Hw for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2013 12:15:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UENMc-0000VV-70 for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2013 12:15:23 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UENMc-0000VQ-37 for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2013 12:15:18 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UENNJ-0007Rl-M8 for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2013 12:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Mar 2013 17:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13687 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13687-submit@debbugs.gnu.org id=B13687.136284934828604 (code B ref 13687); Sat, 09 Mar 2013 17:16:01 +0000 Original-Received: (at 13687) by debbugs.gnu.org; 9 Mar 2013 17:15:48 +0000 Original-Received: from localhost ([127.0.0.1]:42067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UENN5-0007RJ-N9 for submit@debbugs.gnu.org; Sat, 09 Mar 2013 12:15:48 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:48416) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UENN3-0007R6-D7 for 13687@debbugs.gnu.org; Sat, 09 Mar 2013 12:15:46 -0500 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r29HEsRO005155 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 9 Mar 2013 17:14:55 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r29HEsUd009254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 9 Mar 2013 17:14:54 GMT Original-Received: from abhmt105.oracle.com (abhmt105.oracle.com [141.146.116.57]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r29HEq4R029247; Sat, 9 Mar 2013 11:14:52 -0600 Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 09 Mar 2013 09:14:52 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87vc90se5a.fsf@gmail.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac4c529Ccfj3IbswSlWy1xgOal/04QAAOXAA X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72283 Archived-At: > > Do you at least see why your *Messages* logged `exit-minibuffer'? > > ,---- In `read-regexp' > | + (let ((user-defaults (read-regexp-defaults))) > | + (unless (eq user-defaults t) > | + (setq defaults user-defaults) > | + (message "cmd: %s defaults: %S" this-command defaults))) > | + > `---- > > cmd: exit-minibuffer defaults: nil > > > Your code checks only (eq user-defaults t). When > > `user-defaults' is nil, this returns nil. > > The cmd is `exit-minibuffer'. That corresponds to RET in minibuffer > map. I have no other explanation. > > Btw, your explanation is *totally* off the mark. It talks about > defaults in my snippet and not the cmd. NOW I suppose I AM dealing with a dead horse. But in hopes of helping and at the risk of being told once more to f___ off, let me try once more: +(defun read-regexp-defaults () + (if (not read-regexp-user-defaults) t + (let ((user-default (assoc this-command read-regexp-user-defaults))) + (pcase user-default + (`(,cmd ,(and (pred functionp) getter)) + (funcall getter)) + (`nil nil) + (_ t))))) Don't you think that that will return nil when `this-command' = `exit-minibuffer', since `exit-minibuffer' is not in your value of alist `read-regexp-user-defaults'? And if it returns nil, don't you think that the following will then print `cmd: exit-minibuffer defaults: nil'? + (let ((user-defaults (read-regexp-defaults))) + (unless (eq user-defaults t) + (setq defaults user-defaults) + (message "cmd: %s defaults: %S" this-command defaults))) If this doesn't help, I give up and lie down next to your dead horse.