From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sebastian Wiesner Newsgroups: gmane.emacs.bugs Subject: bug#18077: 24.4.50; Info-quoted face should inherit default Date: Fri, 25 Jul 2014 12:25:47 +0200 Message-ID: <7771859.W4ZpDVRkmj@lunaryorn> References: <8761ipn711.fsf@lunaryorn.fritz.box> <83d2ctkfot.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-Trace: ger.gmane.org 1406284050 24691 80.91.229.3 (25 Jul 2014 10:27:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Jul 2014 10:27:30 +0000 (UTC) Cc: 18077@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 25 12:27:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XAcif-0007Aq-N3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Jul 2014 12:27:21 +0200 Original-Received: from localhost ([::1]:54032 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAcif-0003Yf-6n for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Jul 2014 06:27:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAciU-0003Sr-S9 for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 06:27:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAciN-000396-4S for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 06:27:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAciN-000392-0b for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 06:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XAciM-0001gj-A4 for bug-gnu-emacs@gnu.org; Fri, 25 Jul 2014 06:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sebastian Wiesner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Jul 2014 10:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18077 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18077-submit@debbugs.gnu.org id=B18077.14062839696423 (code B ref 18077); Fri, 25 Jul 2014 10:27:02 +0000 Original-Received: (at 18077) by debbugs.gnu.org; 25 Jul 2014 10:26:09 +0000 Original-Received: from localhost ([127.0.0.1]:37393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XAchP-0001fP-OQ for submit@debbugs.gnu.org; Fri, 25 Jul 2014 06:26:08 -0400 Original-Received: from vega.uberspace.de ([95.143.172.245]:49421) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XAchH-0001eu-UO for 18077@debbugs.gnu.org; Fri, 25 Jul 2014 06:26:01 -0400 Original-Received: (qmail 26716 invoked from network); 25 Jul 2014 10:25:53 -0000 Original-Received: from localhost (HELO lunaryorn.localnet) (127.0.0.1) by vega.uberspace.de with SMTP; 25 Jul 2014 10:25:53 -0000 User-Agent: KMail/4.13.3 (Linux/3.15.5-2-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <83d2ctkfot.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91783 Archived-At: > > I do no think that mode faces should *hard-code* specific font families, > > and thus bypass any customization of the default face that the user > > might have made to pick their preferred font. > > > > Besides, courier is not a particularly friendly choice. There is no > > specific font with that name. The actual font depends on the font > > configuration and aliasing picked by the OS and the user, and depending > > on the quality of this configuration the appearance of this font varies > > greatly. If the configuration is particularly poor, or if a proper > > substitute font is missing, Emacs might even fall back to X11 bitmap > > fonts, which are particularly ugly on modern screens. > > > > So just because it's pretty on your screen, it doesn't need to be pretty > > on some else's screen. > > > > Please remove the hard-coded font family and inherit from the default > > face instead. > > Thank you for your report. > > Would you like to suggest a patch for fixing this problem? Please > note that the underlying issue here is that the font should provide > nice-looking glyphs for the Unicode quote characters. I do not think that I am in a position to suggest a patch that could generally fix this problem. I use Emacs only in two different environments, and have no idea of what limits and constraints Emacs must obey with regards to fonts to remain portable across various platforms. I can only say that for my case it would be entirely sufficient to simply make Info-quoted inherit from default, i.e. use '((:inherit default)) as spec in defface. But I only use a GUI Emacs, and only on very recent and modern systems (Arch Linux with KDE, and OS X 10.9), where Unicode fonts are less of a problem. On these systems Emacs typically picks a font with good unicode coverage for the default face automatically, e.g. DejaVu Sans Mono or a variant thereof. Courier however does not exist as a specific family, and might be aliased to something entirely different than the standard monospace font of the system. It could be a fallback URW font, or (even worse) a built-in X11 bitmap font, which looks really ugly, and quite likely has much worse Unicode coverage than the font picked for the default face, if it even has any Unicode support at all. But I do not know whether this is also the case on Windows, or on older X11 environments, that do not use fontconfig, or even still rely on a font server. Still, presuming that the user customized the default face to use a good font with reasonable character coverage (many users do, in my expierence), I think that it is very unlikely that "courier" is a better choice than the font of the default face with regards to Unicode coverage. Also, inheriting from default seems to be the standard among other built-in faces. TL;DR: My suggestion would be to simply inherit from default, with no other attributes set. Sorry for the long comment.