all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Sebastian Wiesner <swiesner@lunaryorn.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18077@debbugs.gnu.org
Subject: bug#18077: 24.4.50; Info-quoted face should inherit default
Date: Fri, 25 Jul 2014 12:25:47 +0200	[thread overview]
Message-ID: <7771859.W4ZpDVRkmj@lunaryorn> (raw)
In-Reply-To: <83d2ctkfot.fsf@gnu.org>

> > I do no think that mode faces should *hard-code* specific font families,
> > and thus bypass any customization of the default face that the user
> > might have made to pick their preferred font.
> > 
> > Besides, courier is not a particularly friendly choice.  There is no
> > specific font with that name.  The actual font depends on the font
> > configuration and aliasing picked by the OS and the user, and depending
> > on the quality of this configuration the appearance of this font varies
> > greatly.  If the configuration is particularly poor, or if a proper
> > substitute font is missing, Emacs might even fall back to X11 bitmap
> > fonts, which are particularly ugly on modern screens.
> > 
> > So just because it's pretty on your screen, it doesn't need to be pretty
> > on some else's screen.
> > 
> > Please remove the hard-coded font family and inherit from the default
> > face instead.
> 
> Thank you for your report.
> 
> Would you like to suggest a patch for fixing this problem?  Please
> note that the underlying issue here is that the font should provide
> nice-looking glyphs for the Unicode quote characters.

I do not think that I am in a position to suggest a patch that could generally 
fix this problem.  I use Emacs only in two different environments, and have no 
idea of what limits and constraints Emacs must obey with regards to fonts to 
remain portable across various platforms.

I can only say that for my case it would be entirely sufficient to simply make 
Info-quoted inherit from default, i.e. use '((:inherit default)) as spec in 
defface.  

But I only use a GUI Emacs, and only on very recent and modern systems (Arch 
Linux with KDE, and OS X 10.9), where Unicode fonts are less of a problem.  On 
these systems Emacs typically picks a font with good unicode coverage for the 
default face automatically, e.g. DejaVu Sans Mono or a variant thereof.

Courier however does not exist as a specific family, and might be aliased to 
something entirely different than the standard monospace font of the system.  
It could be a fallback URW font, or (even worse) a built-in X11 bitmap font, 
which looks really ugly, and quite likely has much worse Unicode coverage than 
the font picked for the default face, if it even has any Unicode support at 
all.

But I do not know whether this is also the case on Windows, or on older X11 
environments, that do not use fontconfig, or even still rely on a font server.

Still, presuming that the user customized the default face to use a good font 
with reasonable character coverage (many users do, in my expierence), I think 
that it is very unlikely that "courier" is a better choice than the font of 
the default face with regards to Unicode coverage.

Also, inheriting from default seems to be the standard among other built-in 
faces.

TL;DR: My suggestion would be to simply inherit from default, with no other 
attributes set.  Sorry for the long comment.






  reply	other threads:[~2014-07-25 10:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22  8:15 bug#18077: 24.4.50; Info-quoted face should inherit default swiesner
2014-07-25  8:25 ` Eli Zaretskii
2014-07-25 10:25   ` Sebastian Wiesner [this message]
2014-07-25 12:11     ` Eli Zaretskii
2014-07-25 14:03       ` Sebastian Wiesner
2014-07-27 23:30         ` Juri Linkov
2014-07-28  8:12           ` Stefan Monnier
2021-04-03 23:58             ` Stefan Kangas
2021-04-04  7:33               ` Eli Zaretskii
2014-07-25 22:37 ` Stefan Monnier
2014-07-25 22:55   ` Sebastian Wiesner
2014-07-26  8:03     ` Stefan Monnier
2014-07-26  8:58       ` Sebastian Wiesner
2014-07-27 10:16         ` Stefan Monnier
2014-07-27 20:04           ` Sebastian Wiesner
2014-07-27 23:23             ` Stefan Monnier
2014-07-28  8:33               ` Sebastian Wiesner
2014-07-26  7:47   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7771859.W4ZpDVRkmj@lunaryorn \
    --to=swiesner@lunaryorn.com \
    --cc=18077@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.