From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height Date: Fri, 19 Mar 2021 09:14:50 +0100 Message-ID: <776ace20-0dfd-d810-639b-ce4c2257ddb1@gmx.at> References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <75bea13b-8302-5317-c4bc-84a710383420@gmx.at> <83lfakfg02.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32861"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, 47234@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 19 09:16:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNAIw-0008S9-PY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Mar 2021 09:16:22 +0100 Original-Received: from localhost ([::1]:50854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNAIv-00014c-PH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Mar 2021 04:16:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNAIc-00012A-7D for bug-gnu-emacs@gnu.org; Fri, 19 Mar 2021 04:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37177) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNAIb-00049R-V8 for bug-gnu-emacs@gnu.org; Fri, 19 Mar 2021 04:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNAIb-0006Ne-N3 for bug-gnu-emacs@gnu.org; Fri, 19 Mar 2021 04:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Mar 2021 08:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47234 X-GNU-PR-Package: emacs Original-Received: via spool by 47234-submit@debbugs.gnu.org id=B47234.161614170221000 (code B ref 47234); Fri, 19 Mar 2021 08:16:01 +0000 Original-Received: (at 47234) by debbugs.gnu.org; 19 Mar 2021 08:15:02 +0000 Original-Received: from localhost ([127.0.0.1]:48717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNAHe-0005SN-3C for submit@debbugs.gnu.org; Fri, 19 Mar 2021 04:15:02 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:57321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNAHc-0005Rr-Au for 47234@debbugs.gnu.org; Fri, 19 Mar 2021 04:15:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1616141692; bh=cvt8v99SUmp4EaplO7cRwrcdtYbvWlioDaYKicX1kDg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=RvWS2oC4BdMOfZYBFBYVS6dkFcX6Jdrv+IdmBj3l1xtVCPxSP3Cj94yrFNzi1O/hs C/DSIZrp7RCyFGiMiU2Kp5+uWcUQ3mBNZvnH7m2dJU7BwWd89+99q8tBWASGVaabLf sEWt2K0kUZYXDJgo4iUHVwSqJWjMo3f2353nx0HY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([213.142.96.218]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N8XU1-1ljWVZ2M2j-014PPu; Fri, 19 Mar 2021 09:14:52 +0100 In-Reply-To: <83lfakfg02.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:eoOqHYVI9Pf+G6fKZwjoWBeV12N8NgtxY5Sus0gssmpX1qxEZMN LHFZ4CE5qRiX7F75qEHrG15XMHpNWGRhVblKsd8b/HK86SNEZtr1+IMUJDvKy1WIqQqnRTX WRr9JPPUNvy93D4uRpKoKYbliQ6YJx1idwQr27FL3uMwIyYjjngMHjZZCxnIeJLs3H/UtRc 5Dqr+pYtuA6wi4wnLl5gQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:cNc36H+eDmQ=:2mIl+Km108p8NuIokJ0vuv wtnOyxhfMWK+G9IKMev/txulP5yvSX2VDtQE20KYJsfIZbG+tL57hMBu65EdgeLUlqLf7sLpx q0WR09zh0MSC6d9/jMwkCe4zmaRuDgnR3apUCSpD+2txHy3ZNy1fX64mhvTFmDlo3hR/iEM5+ LNFYsY0BB2WF0j0cwrZscWwprHtt/StG6QEyRAVL/sl1CfvxH5mqJgd++Vu1wd8aCV770L6E6 I72ZkDLTCdu121c7SXOtq2afqgC8qwvPob7L4H+9MuSEHKSMrMOOhZOgS/ioyXP6VC7EktD1+ UZs4MpjIAKEiZjsb4L8ksYBwUwQ5h1NO+IgDdGQMpNHg/8YAM8jurMHmWR/RohGAhDoPCR3lZ wGv2TWObxQRoSCbGyik67w4WBAxLnK/f4FqPCnnNkP+XTQDsseQfBHogUN8L0/ecR9mkDGluu Hu/iD6TNaHA7KNa6nfHcJHmyUakQO7pBgpnA2446zsmAGQZ1Xw+5RfzAf/2FcwpRi32nIVmAQ Jb8hCnktzTKz7mCK2OZTBrNwrZQIi7JSW7LqkQn1MQGX4jKDwx8pXvGcY2y/4A/cZvZTx+dqd D6fwA+tdSZ+Ko8OTh/5PAdDrSbsSlZaBUkrtGT7JV9UJhNWQGzvHE4BQ60qiNobzLfMQo8Vvp A5MpzbT1KgKI6IT5ugJrGt7GPA5qoHQXUbDBqzhM320AHV6KGXDi/ewjGIhPN4cZnbVha2t6t z/eu2CGs/hhfTm6GwSZQfKQxeR3LFEE1r3cK5Yw9itAycLoK36JfTkMfd8ZACWBtL782m70V X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202665 Archived-At: >> Then it's best to revert the frame.el part of 6c5ddf0e0b. > > Ugh! My apologies. I didn't expect anyone to care about this. For the interested, a short history of that function: When I started to implement child frames for Emacs, I noticed that while on Windows everything worked OOTB, the various GNU/Linux systems I use provided no mouse support for them at all. So to avoid any unpleasant discussions, I had to emulate the entire functionality in Elisp, several hundred lines of code in mouse.el. There, to make sure that child frames don't get too small during dragging, I added a test where I compare the inner height of a frame with that of the minimum size of its root window. It's the inner height because I have to drag the inner border of a frame - GNU/Linux doesn't give me another choice. And I wrote a separate function for retrieving the inner height because `frame-edges' then appeared to expensive for a function running in a tight loop like `mouse-drag-frame-resize'. I didn't care about the menu bar (GNU/Linux generally doesn't like menu bars on child frames) and the tool bar (so far I've not been able to make a tool bar reliably show up on a GTK child frame). So I silently ignored these in `frame-inner-height'. But I did notice recently, that there's no reason why a child frame should _not_ have a tab bar and that's why I made the change. Hence, basically `frame-inner-height' is just an internal function (it lacks the second "-" because it's defined in frame.el and used in mouse.el) supposed to work exclusively in the very limited context of frame dragging. It's of absolutely no use on TTY frames but something born out of the necessity to make Emacs work on systems lacking support for certain features. martin