all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Campbell Barton <ideasman42@gmail.com>
To: emacs-devel@gnu.org
Subject: Bug/regression in regex-replace (was fix for bug#67124)
Date: Sat, 30 Nov 2024 12:24:01 +1100	[thread overview]
Message-ID: <775b1c65-081c-4a91-8a2d-4e7aba04b32c@gmail.com> (raw)

Hi, the commit 47b497b4dac91e5ea56102018223bdeb5e21a93b by Stefan 
Monnier (an alternate fix for bug#67124) has broken the evil-numbers 
package [0], causing it's tests to fail.

 From a user perspective:
`evil-numbers/dec-at-pt` on `0` to result in `1` instead of `-1`.

The change seems to be caused by (set-match-data ...)
using passing in a pair of identical points (a match with zero length), 
then a call to regex-replace to insert text into the empty match (the 
numbers "sign" in this case).

I'm not sure if this would be considered a bug, or if creating an empty 
group is considers incorrect use of the API, in that case - invalid 
input might raise an error instead of failing silently.

Whatever the case this used to work - and the commit doesn't indicate 
the change was intentional.

[0]: https://github.com/juliapath/evil-numbers





             reply	other threads:[~2024-11-30  1:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-30  1:24 Campbell Barton [this message]
2024-11-30  2:49 ` Bug/regression in regex-replace (was fix for bug#67124) ideasman42
2024-11-30  7:24 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=775b1c65-081c-4a91-8a2d-4e7aba04b32c@gmail.com \
    --to=ideasman42@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.