all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: bruce.connor.am@gmail.com
Cc: 22018@debbugs.gnu.org
Subject: bug#22018: 25.0.50; REGRESSION wrt `isearch-new-word'
Date: Thu, 26 Nov 2015 15:44:08 -0800 (PST)	[thread overview]
Message-ID: <774616e6-3d7e-4aa5-b120-812f1c24e0e4@default> (raw)
In-Reply-To: <CAAdUY-+Zg729wAZr-vFbONhbVX7fpDSk4k=yooaq_RFniq9e_g@mail.gmail.com>

> > You essentially did a global replace of `isearch-word' and
> > `isearch-new-word' with `isearch-regexp-function' and
> > `isearch-new-regexp-function'.
> >
> > You provided a `define-obsolete-variable-alias' for `isearch-word',
> > which is a global variable.  But you did nothing to accommodate
> > `isearch-new-word'.
> 
> So adding an alias for isearch-new-word should (in principle)
> fix the issue?

I'm not sure that would be the right fix.  I suggested doing this
inside the `let':

(setq ...
      isearch-regexp-function  (if (boundp 'isearch-new-word)
                                   isearch-new-word
                                 isearch-new-regexp-function)
      ...)

This variable, unlike `isearch-word', exists only locally, bound
by `let'.  An alias (e.g., `defvaralias') would make it a global
variable, no?

That was why I made the above suggestion - to avoid creating a
global variable for this.  But feel free to fix it however you
think is best.





  reply	other threads:[~2015-11-26 23:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 17:10 bug#22018: 25.0.50; REGRESSION wrt `isearch-new-word' Drew Adams
2015-11-26 23:21 ` Artur Malabarba
2015-11-26 23:44   ` Drew Adams [this message]
2015-11-27  0:03     ` Artur Malabarba
2015-11-27  0:05       ` Artur Malabarba
2015-11-27  0:29       ` Drew Adams
2015-11-27 11:26 ` Artur Malabarba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=774616e6-3d7e-4aa5-b120-812f1c24e0e4@default \
    --to=drew.adams@oracle.com \
    --cc=22018@debbugs.gnu.org \
    --cc=bruce.connor.am@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.