all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Alexander Kozhevnikov <mentalisttraceur@gmail.com>,
	63362@debbugs.gnu.org
Subject: bug#63362: Bug+fix for eshell-hist-ignore-dups 'erase
Date: Sun, 14 May 2023 21:46:32 -0700	[thread overview]
Message-ID: <7744f544-d4d0-5975-b960-e5a967a4d8e9@gmail.com> (raw)
In-Reply-To: <CAHUNhcAD=hvpqOxXkiE6FpWf8HR+T0T4DAT0ZgiU4KZJ_BEDcw@mail.gmail.com>

On 5/7/2023 11:38 AM, Alexander Kozhevnikov wrote:
> I think the ideal fix here is a refactor that makes the big picture
> clearer (I can provide one if asked, but that would almost certainly
> have enough creative substance to require copyright assignment, and
> would need to wait on the paperwork).

Thanks for this analysis. I'll try and take a look at this in more 
detail, and perhaps refactor things a bit in this part of the code as 
you suggest. (I've wanted to clean up the Eshell history logic a bit 
already, since I'd like to make it a bit more usable when you have 
multiple Eshell buffers.)

First step though is for me to write up a few regression tests, I think. 
That should make it easier to do some refactoring without breaking anything.





  reply	other threads:[~2023-05-15  4:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-07 17:31 bug#63360: Bug+fix for eshell-hist-ignore-dups 'erase Alexander Kozhevnikov
2023-05-07 18:38 ` bug#63362: " Alexander Kozhevnikov
2023-05-15  4:46   ` Jim Porter [this message]
2023-08-24  1:31   ` bug#63360: " Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7744f544-d4d0-5975-b960-e5a967a4d8e9@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=63362@debbugs.gnu.org \
    --cc=mentalisttraceur@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.