From: Mauro Aranda <maurooaranda@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stephen.berman@gmx.net, 64347@debbugs.gnu.org
Subject: bug#64347: 30.0.50; Some customize faces shown as edited with -Q
Date: Sat, 15 Jul 2023 17:11:21 -0300 [thread overview]
Message-ID: <77337d8b-9bbb-2642-0488-5899d05b76a8@gmail.com> (raw)
In-Reply-To: <83y1jqdeqm.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Fri, 30 Jun 2023 11:05:33 -0300
>> From: Mauro Aranda <maurooaranda@gmail.com>
>> Cc: Stephen Berman <stephen.berman@gmx.net>, Eli Zaretskii
<eliz@gnu.org>
>>
>> To sum it up, I think there are bugs in custom-face-attributes. One is
>> most surely a typo, and the other ones are oversights in the filters for
>> the :underline and :box properties. Fixing those, we are left with one
>> bug, I think, that will be reproducible with Emacs -Q and evaluating:
>>
>> (defface test
>> '((((supports :underline (:style wave)))
>> :underline (:color "Red1" :style wave))
>> (t
>> :inherit warning))
>> "...")
>>
>> (defface test-2
>> '((((supports :underline (:style wave)))
>> :underline (:style wave :color "Red1"))
>> (t
>> :inherit warning))
>> "...")
>>
>> M-x customize-face RET test
>> will show STANDARD state
>>
>> while
>> M-x customize-face RET test-2
>> will show EDITED state
>
> Thanks.
>
> Can you show a patch for the two bugs you've succeeded to identify?
>
> Did you make any progress with the one bug that's left after the other
> two are fixed?
Here's a patch for the typo.
Concerning the other bugs I discovered, I think that while the filters
could be tweaked, a better fix would be to teach face-spec-match-p
about matching plists correctly and not just by equality.
[-- Attachment #2: 0001-Fix-typo-in-pre-filter-for-underline-property.patch --]
[-- Type: text/x-patch, Size: 979 bytes --]
From 409b59f21fec542e16740bfa62daf09df4cdcecb Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Sat, 15 Jul 2023 17:05:23 -0300
Subject: [PATCH] Fix typo in pre-filter for underline property
* lisp/cus-face.el (custom-face-attributes): Fix typo (Bug#64347)
---
lisp/cus-face.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/cus-face.el b/lisp/cus-face.el
index ec89b4f7ff6..a3a27263a7c 100644
--- a/lisp/cus-face.el
+++ b/lisp/cus-face.el
@@ -158,7 +158,7 @@ custom-face-attributes
(or (and (consp real-value) (plist-get real-value :style))
'line))
(position (and (consp real-value)
- (plist-get real-value :style))))
+ (plist-get real-value :position))))
(list :color color :style style :position position))))
;; filter to make customized-value suitable for storing
,(lambda (cus-value)
--
2.34.1
next prev parent reply other threads:[~2023-07-15 20:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 10:15 bug#64347: 30.0.50; Some customize faces shown as edited with -Q Stephen Berman
2023-06-29 12:38 ` Eli Zaretskii
2023-06-30 11:33 ` Mauro Aranda
2023-06-30 12:43 ` Drew Adams
2023-06-30 14:05 ` Mauro Aranda
2023-07-08 7:49 ` Eli Zaretskii
2023-07-08 21:32 ` Mauro Aranda
2023-07-09 5:43 ` Eli Zaretskii
2023-07-09 11:44 ` Mauro Aranda
2023-07-09 12:13 ` Eli Zaretskii
2023-07-09 23:12 ` Mauro Aranda
2023-07-10 12:47 ` Eli Zaretskii
2023-07-10 13:45 ` Mauro Aranda
2023-07-15 20:01 ` Mauro Aranda
2023-07-20 15:45 ` Eli Zaretskii
2023-07-15 20:11 ` Mauro Aranda [this message]
2023-07-20 15:49 ` Eli Zaretskii
2023-07-20 18:56 ` Mauro Aranda
2023-07-20 19:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77337d8b-9bbb-2642-0488-5899d05b76a8@gmail.com \
--to=maurooaranda@gmail.com \
--cc=64347@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.