From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history' Date: Thu, 20 Apr 2023 01:24:04 +0300 Message-ID: <7723fbd0-cd06-fc92-a1d6-291113580d0c@gutov.dev> References: <97545727-7123-ca74-3d2e-4ac5c6d8f25a@gutov.dev> <1310e385-f151-2a96-d7b9-cd21c082adc3@gutov.dev> <360f88a8-8dd9-5fd3-51ef-4b670aad2272@gutov.dev> <7717d45c-b88c-5956-1018-dd86d44cd25f@gutov.dev> <61ab8e9c-0265-051f-c0e9-4e3094e12789@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10018"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Daniel Mendler , Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= , 62776-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 20 00:25:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppGEt-0002M1-4o for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Apr 2023 00:25:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppGEa-0005KI-87; Wed, 19 Apr 2023 18:25:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppGEY-0005Jd-6u for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 18:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppGEX-0001Go-UB for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 18:25:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppGEX-0007dd-PG for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 18:25:01 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Apr 2023 22:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62776 X-GNU-PR-Package: emacs Mail-Followup-To: 62776@debbugs.gnu.org, dmitry@gutov.dev, salutis@me.com Original-Received: via spool by 62776-done@debbugs.gnu.org id=D62776.168194305529292 (code D ref 62776); Wed, 19 Apr 2023 22:25:01 +0000 Original-Received: (at 62776-done) by debbugs.gnu.org; 19 Apr 2023 22:24:15 +0000 Original-Received: from localhost ([127.0.0.1]:36061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppGDm-0007cN-KZ for submit@debbugs.gnu.org; Wed, 19 Apr 2023 18:24:14 -0400 Original-Received: from new2-smtp.messagingengine.com ([66.111.4.224]:36239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppGDk-0007cB-KT for 62776-done@debbugs.gnu.org; Wed, 19 Apr 2023 18:24:13 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 3D1945821E2; Wed, 19 Apr 2023 18:24:07 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 19 Apr 2023 18:24:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1681943047; x=1681946647; bh=Kh9KfDnj+5VNII9cH9OJJ1xsJ6t6Gn8O1BA mXMiiaSw=; b=KZJ3AW01KRAk+OKXFLtv6L7Wc9/knfwK8nWkaWTUW6rE9K2VwB6 ei7qmU25w6egsCj845VS7ERO3/9tJ1qcQoaRd/0b5ht8fxWkERgbWpGHEDhS22B9 JcF1I8BzoNXzlJioJFXunspilARTCqJCAdYney8vkUJaAlus5WH+ITWTfKzbaCAU wthkLSuHxXdN3BtLXmHzIuFrwMXJzHdmgMQr9wm9uG/U8Mhsca0ENtHzUdKFRjWd dKs/HELvyE4vYn87sMgEo5g0o5YEkTuKj7vfOjG26HDxsiac3GMd4TDnypHBlIf4 9cS1bYxGZ5d02pwWnsNS8llg014lut6koog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681943047; x= 1681946647; bh=Kh9KfDnj+5VNII9cH9OJJ1xsJ6t6Gn8O1BAmXMiiaSw=; b=M 2avlsuUXO/ZgEqUIwkOEtjKJooIjy1/MS6ldA7mNehB12eAAplfwqjlr2WkGcKaz g44b9IO5UhPsCWjxr2dLprrZnz/gkcJb0Hdl4ZwzXmE6cg5MadzU0+cTyTAn1aoA nazQ/QFTRCDGDBvARDmvH2tk/tljA7g2E8AIoZkde0Mk8CdLHXUHfWt+wO3E2Qiq tp2rFyvLYiwOyKbuyY6e84Hnvf5PHe78iADCmLu/ADGMncWKvGQcptJ8Ko2unB4k WOJqYbB0HTQTLZyn5nIb922Fru+qMOMHsN5xeAr+LkKdkp/R3urdLCzQY8zE3YAB tG4SNrdy+qwmzGwgp3Sdg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtuddgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtje ertddtfeejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhepvdeljeelgeehtdduvdetudfgfeejje fgleevteehvdfhffelvdfhteevhffghfegnecuffhomhgrihhnpehgihhthhhusgdrtgho mhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Apr 2023 18:24:05 -0400 (EDT) Content-Language: en-US In-Reply-To: <61ab8e9c-0265-051f-c0e9-4e3094e12789@daniel-mendler.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260299 Archived-At: On 19/04/2023 20:07, Daniel Mendler wrote: > On 4/19/23 17:49, Dmitry Gutov wrote: >> On 19/04/2023 18:46, Daniel Mendler wrote: >>>> IIUC the issue is that is has (added) special handling for file name >>>> completion, and predicates that on the name of the history variable. It >>>> can/should be combined with an extra check which makes sure that the >>>> completion table uses '/' as field separators. Maybe using the >>>> `completion-boundaries` thingy. Or just straight calling >>>> `completion-boundaries` on the history elements to extract the first >>>> segment instead of hardcoding '/'. >>> Vertico already handles completion boundaries. This is how the base >>> string `vertico--base` is computed. But as already mentioned, this is >>> unfortunately not the only issue. The issue is also that >>> `project-find-file` removes the base directory. The entries in the >>> history hash would need the same treatment. >> But they do: the dynamically bound value of file-name-history at the >> moment when completing-read is called contain only the relative file >> names (with base directory removed). >> >> That was the recent change in project.el we are referring to. > Ok okay, thanks! I didn't understand that. This makes a lot of sense > since then the history only contains valid values. Then you are right > that it is actually quite easy to repair the completion boundary issue > in `vertico--history-hash`. Now fixed in https://github.com/minad/vertico/commit/ee148c0cb72f8ea306bf6bab3ef83f928cf82005. Thanks all! Closing.