From: Dmitry Gutov <dmitry@gutov.dev>
To: "Daniel Mendler" <mail@daniel-mendler.de>,
"Rudolf Adamkovič" <salutis@me.com>,
62776@debbugs.gnu.org
Subject: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history'
Date: Wed, 19 Apr 2023 18:49:39 +0300 [thread overview]
Message-ID: <7717d45c-b88c-5956-1018-dd86d44cd25f@gutov.dev> (raw)
In-Reply-To: <b39eeb0f-40ce-4a9b-d479-da27492e8696@daniel-mendler.de>
On 19/04/2023 18:46, Daniel Mendler wrote:
>> IIUC the issue is that is has (added) special handling for file name
>> completion, and predicates that on the name of the history variable. It
>> can/should be combined with an extra check which makes sure that the
>> completion table uses '/' as field separators. Maybe using the
>> `completion-boundaries` thingy. Or just straight calling
>> `completion-boundaries` on the history elements to extract the first
>> segment instead of hardcoding '/'.
> Vertico already handles completion boundaries. This is how the base
> string `vertico--base` is computed. But as already mentioned, this is
> unfortunately not the only issue. The issue is also that
> `project-find-file` removes the base directory. The entries in the
> history hash would need the same treatment.
But they do: the dynamically bound value of file-name-history at the
moment when completing-read is called contain only the relative file
names (with base directory removed).
That was the recent change in project.el we are referring to.
next prev parent reply other threads:[~2023-04-19 15:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 15:21 bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history' Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 1:18 ` Dmitry Gutov
2023-04-18 21:38 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-19 1:54 ` Dmitry Gutov
2023-04-19 5:54 ` Daniel Mendler
2023-04-19 10:47 ` Dmitry Gutov
2023-04-19 12:05 ` Daniel Mendler
2023-04-19 15:28 ` Dmitry Gutov
2023-04-19 15:46 ` Daniel Mendler
2023-04-19 15:49 ` Dmitry Gutov [this message]
2023-04-19 17:07 ` Daniel Mendler
2023-04-19 22:24 ` Dmitry Gutov
[not found] ` <handler.62776.D62776.168194305529292.notifdone@debbugs.gnu.org>
2023-04-24 9:20 ` bug#62776: closed (Re: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history') Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7717d45c-b88c-5956-1018-dd86d44cd25f@gutov.dev \
--to=dmitry@gutov.dev \
--cc=62776@debbugs.gnu.org \
--cc=mail@daniel-mendler.de \
--cc=salutis@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.