From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.bugs Subject: bug#41684: [PATCH] Highlight typed variables in python Date: Sat, 13 Jun 2020 11:57:44 +0300 Message-ID: <7711d0a2c41e4cb2c4d41527e608eed273221228.camel@yandex.ru> References: <20200603115103.69611-1-Hi-Angel@yandex.ru> <83ftaz4dvd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="21449"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.36.3 Cc: 41684-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 13 10:58:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jk1zQ-0005RA-3Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jun 2020 10:58:12 +0200 Original-Received: from localhost ([::1]:35212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jk1zO-0007T5-Ka for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jun 2020 04:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jk1zG-0007Se-5D for bug-gnu-emacs@gnu.org; Sat, 13 Jun 2020 04:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jk1zF-0007Dg-Sq for bug-gnu-emacs@gnu.org; Sat, 13 Jun 2020 04:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jk1zF-00006N-Sh for bug-gnu-emacs@gnu.org; Sat, 13 Jun 2020 04:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konstantin Kharlamov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jun 2020 08:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41684 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41684-done@debbugs.gnu.org id=D41684.1592038675379 (code D ref 41684); Sat, 13 Jun 2020 08:58:01 +0000 Original-Received: (at 41684-done) by debbugs.gnu.org; 13 Jun 2020 08:57:55 +0000 Original-Received: from localhost ([127.0.0.1]:40828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk1z9-000062-Av for submit@debbugs.gnu.org; Sat, 13 Jun 2020 04:57:55 -0400 Original-Received: from forward104p.mail.yandex.net ([77.88.28.107]:40048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk1z7-00005o-3Q for 41684-done@debbugs.gnu.org; Sat, 13 Jun 2020 04:57:54 -0400 Original-Received: from mxback13o.mail.yandex.net (mxback13o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::64]) by forward104p.mail.yandex.net (Yandex) with ESMTP id 880804B00CDA; Sat, 13 Jun 2020 11:57:46 +0300 (MSK) Original-Received: from sas2-ee0cb368bd51.qloud-c.yandex.net (sas2-ee0cb368bd51.qloud-c.yandex.net [2a02:6b8:c08:b7a3:0:640:ee0c:b368]) by mxback13o.mail.yandex.net (mxback/Yandex) with ESMTP id WCENcrenj4-vkwO3ulQ; Sat, 13 Jun 2020 11:57:46 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1592038666; bh=jxksrcnZPBngRaFLCnHGEHm+adoDd5kz/fT9IxW+9yI=; h=In-Reply-To:Cc:To:From:Subject:References:Date:Message-ID; b=eH2z0fbtyrei1dO+/du5+Jmn4Mcnzcn2ZEFe9jxRQe44LYDCQkNQ12JCAo2PzJ0ou 6OOJdC86EJ7d0Z9ghnvgvdReE4v2Te7LeIrUOBxhg5Uaji2vcXc3GNWVXvyeC7G8b9 Qp2k8lko20cOp7xCNM2KbOocTHDGRBVo+TsKh7Vg= Authentication-Results: mxback13o.mail.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: by sas2-ee0cb368bd51.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id s4spH787Ib-vjWWHZpD; Sat, 13 Jun 2020 11:57:45 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) In-Reply-To: <83ftaz4dvd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181907 Archived-At: On Sat, 2020-06-13 at 10:35 +0300, Eli Zaretskii wrote: > > From: Konstantin Kharlamov > > Date: Wed, 3 Jun 2020 14:51:03 +0300 > > > > * progmodes/python.el (python-font-lock-keywords-maximum- > > decoration): > > recognize typed variables like "foo: int = 1" as well. > > --- > > Thanks, I installed this on the master branch. Thanks! > For the future, please note a couple of minor stylistic nits: > > . it is better to submit patches in "git format-patch" format, as > that makes it easier to apply the patch Hmm, okay… The patch was sent with git-send-email command, is it different from git-format-patch? I used to see projects that in our days still use (or have used) email for patches recommend specifically sending patches with git-send-email, so it is a bit unusual requirement, but I'll try to remember. > . the description in the log message should start with a capital > letter after the function's name Okay, thanks. I'll try to remember, although it is unusual too, because AFAIK from grammar standpoint a sentence continuation after a colon ":" symbol should be lower-case. > . if a comment or a code line exceeds 80 columns, break them into > several lines