Re: comint fix for shell colors

[Erik Selberg <erik@selberg.org>]

Thanks for the feedback, I'll rebase.

I do believe this is needed; when the shell prompt is multicolor (for examine using the agnoster theme as shown in the screenshot) applying a face removes the shell coloring.

Cheers,
-e

Sent from my iPhone

On Nov 18, 2016, at 7:34 AM, Eli Zaretskii <eliz@gnu.org> wrote:

>> Date: Fri, 18 Nov 2016 16:06:28 +0100
>> From: Wolfgang Jenkner <wjenkner@inode.at>
>> Cc: erik@selberg.org, emacs-devel@gnu.org
>> 
>>> Indeed, I think this change should be described in NEWS.  Could you
>>> provide a patch for that, please?
>> 
>> Please note that there's nothing new here, it was just a bug fix.
>> The very first message in the bug report mentioned above states
>> 
>>        In Emacs 24.3, comint-highlight-prompt allows ANSI colors to show through
>>        if it does not specify any colors itself. In Emacs 24.4, it does not, even
>>        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>        if comint-highlight-prompt is the "empty face".
> 
> Then how do you explain the OP's confusion on this matter?
>