From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#8613: "mode:" for minor-mode breaks set-visited-file-name Date: Mon, 09 May 2011 19:41:16 -0400 Message-ID: <76pqnrjvc3.fsf@fencepost.gnu.org> References: <3gk4dzo7h6.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1304993002 19264 80.91.229.12 (10 May 2011 02:03:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 10 May 2011 02:03:22 +0000 (UTC) Cc: 8613@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 10 04:03:18 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QJcI9-00035l-CC for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 May 2011 04:03:17 +0200 Original-Received: from localhost ([::1]:52825 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJcI8-0002Rt-E6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 May 2011 22:03:16 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:40101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJcI6-0002Ro-0H for bug-gnu-emacs@gnu.org; Mon, 09 May 2011 22:03:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QJcI4-0004mx-Vz for bug-gnu-emacs@gnu.org; Mon, 09 May 2011 22:03:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJa5S-0001Ps-CF for bug-gnu-emacs@gnu.org; Mon, 09 May 2011 19:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QJa5R-00059x-Nk; Mon, 09 May 2011 19:42:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2011 23:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8613 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8613-submit@debbugs.gnu.org id=B8613.130498448419773 (code B ref 8613); Mon, 09 May 2011 23:42:01 +0000 Original-Received: (at 8613) by debbugs.gnu.org; 9 May 2011 23:41:24 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJa4q-00058r-Fr for submit@debbugs.gnu.org; Mon, 09 May 2011 19:41:24 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJa4o-00058f-HC for 8613@debbugs.gnu.org; Mon, 09 May 2011 19:41:23 -0400 Original-Received: from localhost ([127.0.0.1]:33028) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJa4i-00079B-Um; Mon, 09 May 2011 19:41:17 -0400 X-Spook: ANDVT Al Jazeera encryption brigand North Korea Vickie X-Ran: $W#;lZzwaI)Ve8Q`#G(pG^MUv"v7zev#^~-[=uqyJgR}Oy,AFQ3(H;K$17j1xa(nE"N()1 X-Hue: red X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 09 May 2011 19:42:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46365 Archived-At: Do you have a preference for a solution? Here's the hack-one-local-variable-eval-safep version: *** lisp/files.el 2011-04-24 00:24:30 +0000 --- lisp/files.el 2011-05-09 23:22:07 +0000 *************** *** 3327,3332 **** --- 3327,3336 ---- ;; Certain functions can be allowed with safe arguments ;; or can specify verification functions to try. (and (symbolp (car exp)) + ;; Allow (minor)-modes calls with no arguments. + ;; This obsoletes the use of "mode:" for such things. (Bug#8613) + (or (and (null (cdr exp)) + (string-match "-mode\\'" (symbol-name (car exp)))) (let ((prop (get (car exp) 'safe-local-eval-function))) (cond ((eq prop t) (let ((ok t)) *************** *** 3341,3347 **** (dolist (function prop) (if (funcall function exp) (setq ok t))) ! ok))))))) (defun hack-one-local-variable (var val) "Set local variable VAR with value VAL. --- 3345,3351 ---- (dolist (function prop) (if (funcall function exp) (setq ok t))) ! ok)))))))) (defun hack-one-local-variable (var val) "Set local variable VAR with value VAL.