From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#41445: 26.3; Query-replace triggers "match data clobbered by..." Date: Sat, 23 May 2020 13:36:37 +0200 Message-ID: <76CFF420-CB1C-464A-A67C-22D813C00EB8@acm.org> References: <83367s4427.fsf@gnu.org> <370FA0D9-1EF2-4EC4-977C-C20106CF222D@acm.org> <83wo542mwz.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="30420"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ture@turepalsson.se, 41445@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 23 13:37:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jcSSj-0007mU-SL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 May 2020 13:37:10 +0200 Original-Received: from localhost ([::1]:58940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcSSi-00043H-Gj for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 May 2020 07:37:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcSSc-00042y-7J for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 07:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcSSb-0005AM-Uj for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 07:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcSSb-0001Yt-R9 for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 07:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 May 2020 11:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41445 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41445-submit@debbugs.gnu.org id=B41445.15902338055982 (code B ref 41445); Sat, 23 May 2020 11:37:01 +0000 Original-Received: (at 41445) by debbugs.gnu.org; 23 May 2020 11:36:45 +0000 Original-Received: from localhost ([127.0.0.1]:33529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcSSL-0001YP-4h for submit@debbugs.gnu.org; Sat, 23 May 2020 07:36:45 -0400 Original-Received: from mail158c50.megamailservers.eu ([91.136.10.168]:44650 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcSSI-0001YG-Or for 41445@debbugs.gnu.org; Sat, 23 May 2020 07:36:43 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1590233800; bh=FkF0gyJvKd8lO8eJJMRIsg3TNkE14pTnL6OpyBNHCLA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=UxlBGztTq7ddIHvsX77cLNHQUBMEbHnGyya0mcg6C5nmsLwDl1tfnjOr/fgpGLp/m dSDcbZeqtwvDTKMIp9RJWZuJmEbD7TlXDM/BjawWS0B97j6CkL59JuMJ25oh+XHoN2 HaWUuyTzA3hx46WOdZzhDfUoxELBLm0uHt2160o0= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-4e4ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.78]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 04NBabRE006317; Sat, 23 May 2020 11:36:39 +0000 In-Reply-To: <83wo542mwz.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F24.5EC90A6A.002D:SCFSTAT68638221, ss=1, re=-4.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: -4.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=MOMeZ/Rl c=1 sm=1 tr=0 a=klNLuyVZdLUgl+K5Uafb2A==:117 a=klNLuyVZdLUgl+K5Uafb2A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=UoQy_O0IALNQMqpdxYEA:9 a=CjuIK1q_8ugA:10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180791 Archived-At: > My line of reasoning was that only the callers of ENCODE_FILE and > DECODE_FILE will not expect the match-data to be clobbered. Code that > calls ucs-normalize-region directly may or may not be bothered by the > clobbering, so we should leave that to the caller. >=20 > The advantage of not doing this unconditionally is that we don't > unnecessarily punishing callers that don't need match-data to be > saved. For callers of the ucs-normalize- functions, correctness should come = first; their names, semantics or descriptions do not lead the user to = suspect them of clobbering the match data. It is an implementation = leakage which can be quite unexpected, as is witnessed by this bug. For example, in one of the few calls I could find at all, this might be = classified as a near-miss, only saved by the left-to-right argument = evaluation order: (lookup-new-entry=20 'regular dictionary (match-string 0) (ucs-normalize-HFS-NFC-string (match-string 1))))