From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add xwidget webkit support for macOS Cocoa Date: Sat, 25 May 2019 23:02:10 -0700 Organization: UCLA Computer Science Department Message-ID: <768c3ba1-d494-154f-b752-ff32cfb3085a@cs.ucla.edu> References: <20190525132727.94982-1-pcr910303@icloud.com> <679B30F5-4AB8-4F70-AEA1-A428538E928B@icloud.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="213651"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: emacs-devel@gnu.org To: =?UTF-8?B?7KGw7ISx67mI?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 26 08:02:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hUmF8-000tRG-Hc for ged-emacs-devel@m.gmane.org; Sun, 26 May 2019 08:02:50 +0200 Original-Received: from localhost ([127.0.0.1]:51287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUmF6-0007qo-V1 for ged-emacs-devel@m.gmane.org; Sun, 26 May 2019 02:02:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUmEY-0007qj-P0 for emacs-devel@gnu.org; Sun, 26 May 2019 02:02:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUmEX-00034y-VG for emacs-devel@gnu.org; Sun, 26 May 2019 02:02:14 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:47522) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hUmEX-00034n-Pt for emacs-devel@gnu.org; Sun, 26 May 2019 02:02:13 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E7693161335; Sat, 25 May 2019 23:02:11 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id jnvmg81ZaTGW; Sat, 25 May 2019 23:02:11 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3983D161889; Sat, 25 May 2019 23:02:11 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5ddoeDcPikl0; Sat, 25 May 2019 23:02:11 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 06F39161335; Sat, 25 May 2019 23:02:11 -0700 (PDT) In-Reply-To: <679B30F5-4AB8-4F70-AEA1-A428538E928B@icloud.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237004 Archived-At: =EC=A1=B0=EC=84=B1=EB=B9=88 wrote: > Can you give some candidates to use? Perhaps the 'message' function? >>> +#if defined (USE_GTK) >>> #if WEBKIT_CHECK_VERSION (2, 21, 1) && GNUC_PREREQ (4, 2, 0) >>> # pragma GCC diagnostic ignored "-Wdeprecated-declarations" >>> #endif >>> +#endif >> >> Use just one "#if" rather than nested ones. >=20 > That one was because the macro WEBKIT_CHECK_VERSION is only defined in = GTK webkit... Last time I looked, I remember being puzzled because C prep= rocessor didn=E2=80=99t do proper short circuiting?=CC=8A=CC=88 I=E2=80=99= ll try that again. Oh, you're right. Please ignore my suggestion there.