From: Paul Eggert <eggert@cs.ucla.edu>
To: 조성빈 <pcr910303@icloud.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Add xwidget webkit support for macOS Cocoa
Date: Sat, 25 May 2019 23:02:10 -0700 [thread overview]
Message-ID: <768c3ba1-d494-154f-b752-ff32cfb3085a@cs.ucla.edu> (raw)
In-Reply-To: <679B30F5-4AB8-4F70-AEA1-A428538E928B@icloud.com>
조성빈 wrote:
> Can you give some candidates to use?
Perhaps the 'message' function?
>>> +#if defined (USE_GTK)
>>> #if WEBKIT_CHECK_VERSION (2, 21, 1) && GNUC_PREREQ (4, 2, 0)
>>> # pragma GCC diagnostic ignored "-Wdeprecated-declarations"
>>> #endif
>>> +#endif
>>
>> Use just one "#if" rather than nested ones.
>
> That one was because the macro WEBKIT_CHECK_VERSION is only defined in GTK webkit... Last time I looked, I remember being puzzled because C preprocessor didn’t do proper short circuiting?̊̈ I’ll try that again.
Oh, you're right. Please ignore my suggestion there.
next prev parent reply other threads:[~2019-05-26 6:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 13:27 [PATCH] Add xwidget webkit support for macOS Cocoa Sungbin Jo
2019-05-25 17:47 ` Paul Eggert
2019-05-26 2:57 ` 조성빈
2019-05-26 6:02 ` Paul Eggert [this message]
2019-05-28 15:07 ` [PATCH v2] " 조성빈
2019-06-02 6:14 ` 조성빈
2019-06-02 14:39 ` Eli Zaretskii
2019-06-03 16:11 ` Alan Third
2019-06-03 17:25 ` Stefan Monnier
2019-06-03 23:36 ` Paul Eggert
2019-06-03 23:51 ` Sungbin Jo
2019-06-04 2:40 ` Stefan Monnier
2019-06-04 8:33 ` Andreas Schwab
2019-06-05 3:06 ` Sungbin Jo
2019-06-05 3:18 ` [PATCH v3] " Sungbin Jo
2019-06-05 13:55 ` Stefan Monnier
2019-06-05 14:34 ` Eli Zaretskii
2019-06-23 22:38 ` Alan Third
2019-06-04 16:22 ` [PATCH v2] " Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=768c3ba1-d494-154f-b752-ff32cfb3085a@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=pcr910303@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.