From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation Date: Thu, 15 Dec 2022 22:09:10 -0800 Message-ID: <765547c0-b2a5-b054-a29d-b27002b7442c@gmail.com> References: <83iliiv0yv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18357"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arstoffel@gmail.com, Stefan Monnier , 59956@debbugs.gnu.org To: Gregory Heytings , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 16 07:10:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p63vD-0004dp-D2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Dec 2022 07:10:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p63v3-0006fD-GY; Fri, 16 Dec 2022 01:10:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p63v0-0006ci-Le for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 01:10:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p63v0-00073z-Br for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 01:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p63uz-0004BU-Ni for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 01:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Dec 2022 06:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59956 X-GNU-PR-Package: emacs Original-Received: via spool by 59956-submit@debbugs.gnu.org id=B59956.167117096116058 (code B ref 59956); Fri, 16 Dec 2022 06:10:01 +0000 Original-Received: (at 59956) by debbugs.gnu.org; 16 Dec 2022 06:09:21 +0000 Original-Received: from localhost ([127.0.0.1]:47297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p63uL-0004Aw-JO for submit@debbugs.gnu.org; Fri, 16 Dec 2022 01:09:21 -0500 Original-Received: from mail-pg1-f174.google.com ([209.85.215.174]:38700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p63uH-0004Ao-GF for 59956@debbugs.gnu.org; Fri, 16 Dec 2022 01:09:20 -0500 Original-Received: by mail-pg1-f174.google.com with SMTP id w37so1113855pga.5 for <59956@debbugs.gnu.org>; Thu, 15 Dec 2022 22:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=CsSOBNSP41rYN446/ynbYssgHUN7Dqh2odwcCoetAvw=; b=Zdb6izBed1VzI9DdQS3oBIQAbATmzY+Z4oEVvThYkAJtv+2SHjc2UfLKPnqAqseg0O A2TWlrNditqNjQQ5pcBWiCgBuNvp7va05XR08D27DhtttVHGa4ZTtaZWFGH+pfuxAcuq 1/1DLkugfjOdX+dyWhVGKykgCcgSd1dBtTM0z4Mw+yrjppBAgOpxYAtO1jv62K2v//WC +GMLHqz+pzG+NU25xC3DS/aZkeLyG+az2F9Nik2Bv4vqrpIHyXIpT274mhuqmZzzsnh6 AxOWGC8cqbfzYXjZBOS/0oQieRyBK6YQ5kP0UjUA6KBK5aoMFHZoY2tPacgmcJioIswM 20eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CsSOBNSP41rYN446/ynbYssgHUN7Dqh2odwcCoetAvw=; b=CtXPzaUjloEW4cAsUnEWNt0A2+0wg6TeRFFKuK+9uKKwozK+/K17H5mva5LfI9JWtk ZteS0dHpknVe9GIDwhoTsGvuVa++oGGTQIGS+3ZmM/NUviZJKz54b+LONSNz9OidAkEB z6stt1wDnRr7wqNpt/7lMwet7uxFGaha+iR8QsC96zGB1WlJJG99k6BmCveE9SrFnmlQ kVE2eFkljbvCQXUAJ65fslz2eur1f1Soudsy+bvFrDjtn79+KWV2uFYrXd9p8Z9Uzrno OPze52flCrqtuNH38gqCHfYDydH1V3ILkK3hX9MDkqucFoGPmq7Z0atgjTs3og/lXisJ itIA== X-Gm-Message-State: ANoB5pk3CKt/GUIVAcJvQpvbd+apB3BLRQbGao4kIElDRFoqeFuutQbO NkUs3iTcUFRMdgamkUPuVGM= X-Google-Smtp-Source: AA0mqf789pKINQQoJ9V4jzAmCXlUZh80Yf79u2UR9/3/UzjpH5x4idWY86eqv0evSBWJnobYOfzczQ== X-Received: by 2002:a05:6a00:2bb:b0:57a:9b14:69b7 with SMTP id q27-20020a056a0002bb00b0057a9b1469b7mr14245206pfs.0.1671170951560; Thu, 15 Dec 2022 22:09:11 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i73-20020a62874c000000b0056bc5ad4862sm622804pfe.28.2022.12.15.22.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 22:09:10 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251179 Archived-At: On 12/12/2022 2:21 PM, Gregory Heytings wrote: > I'm still not Stefan, but this bug is fixed by the attached patch. Thanks. This is pretty close to what I was thinking (I tried almost the exact same patch locally, but wasn't sure if there was a better way). Personally, I think something like your patch would probably be the safest bet for the 29 branch. Still, like Stefan and Augusto mentioned, there's probably a larger issue here: should Eshell be allowed to feed Pcomplete non-strings? Since Pcomplete was written for Eshell initially, there's some basis for why it *might* support non-string values, but actually requiring that is an awful lot to ask of every programmer who ever wants to write a pcomplete function.