bug#40600: [PATCH] 27.0.90; M-x strokes-list-strokes error

[tsuucat via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

> Why use prin1-to-string?

That’s simply because I imitate the code in strokes-list-strokes function.

> Actually, since string-lessp accepts symbols, an easier fix would be to
> just drop the calls to symbol-name.


Thanks for the advice! I made another patch and checked this  works well.

--
tsuucat

[-- Attachment #2: 0001-Fix-comparing-command-names-in-strokes.el-bug-40600.patch --]
[-- Type: application/octet-stream, Size: 1032 bytes --]

From af31735e07528973392cb1e163f9f9e1682951e4 Mon Sep 17 00:00:00 2001
From: Masahiro Nakamura <tsuucat@icloud.com>
Date: Tue, 14 Apr 2020 22:37:17 +0900
Subject: [PATCH] Fix comparing command names in strokes.el (bug#40600)

* lisp/strokes.el (strokes-alphabetic-lessp): Simply call string-lessp
because the cdr of the argument may be string.
---
 lisp/strokes.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lisp/strokes.el b/lisp/strokes.el
index 7a887445..e511a63f 100644
--- a/lisp/strokes.el
+++ b/lisp/strokes.el
@@ -1373,9 +1373,7 @@ strokes-list-strokes
 
 (defun strokes-alphabetic-lessp (stroke1 stroke2)
   "Return t if STROKE1's command name precedes STROKE2's in lexicographic order."
-  (let ((command-name-1 (symbol-name (cdr stroke1)))
-	(command-name-2 (symbol-name (cdr stroke2))))
-    (string-lessp command-name-1 command-name-2)))
+  (string-lessp (cdr stroke1) (cdr stroke2)))
 
 (defvar strokes-mode-map
   (let ((map (make-sparse-keymap)))
-- 
2.21.0