Re: [PATCH] Clean up a couple of compiler warnings

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

Philipp Stephani wrote:
> This apparently hasn't worked, at least I still get the warning, and
> there's no -Wno-missing-braces in WARN_CFLAGS.

My change didn't add -Wno-missing-braces; it removed -Wmissing-braces. This 
sufficed for Fedora 25 x86-64, which has clang 3.9.1.

Perhaps you're running a different version of Clang, which is pickier? If so, 
you might try the attached patch; if it works, please feel free to install it.

> For Clang, it'd probably be better to use -Weverything and then disable
> individual warnings with -Wno

I'd rather not spend a lot of time worrying about warnings generated by 
compilers other than recent GCC, as there are too many compilers and too many 
false alarms and it's not worth the hassle. If you'd like to take up the burden 
of pacifying Clang with tricks like the above, though, that should be fine, as 
long as it doesn't burden maintenance for the rest of us. If not, and if Clang 
continues to be a hassle, we can avoid much of the hassle by disabling warnings 
by default when the compiler is Clang.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: clang.diff --]
[-- Type: text/x-patch; name="clang.diff", Size: 402 bytes --]

diff --git a/configure.ac b/configure.ac
index 12e44d9..6d23b5d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -986,6 +986,7 @@ AC_DEFUN
 
   # More things that clang is unduly picky about.
   if test $emacs_cv_clang = yes; then
+    gl_WARN_ADD([-Wno-missing-braces])
     gl_WARN_ADD([-Wno-tautological-compare])
     gl_WARN_ADD([-Wno-tautological-constant-out-of-range-compare])
   fi