From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Date: Tue, 20 Aug 2019 10:19:29 +0200 Message-ID: <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="135092"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 9867@debbugs.gnu.org To: Lars Ingebrigtsen , Christoph Scholtes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 20 10:20:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzzNT-000Yxf-Pa for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Aug 2019 10:20:27 +0200 Original-Received: from localhost ([::1]:34526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzzNS-0006pE-Ab for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Aug 2019 04:20:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53380) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzzN7-0006oV-M1 for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 04:20:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzzN6-0002F9-GK for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 04:20:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52039) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzzN4-0002Ej-Sx for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 04:20:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hzzN4-0006FO-JK for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 04:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 08:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156628918723987 (code B ref 9867); Tue, 20 Aug 2019 08:20:02 +0000 Original-Received: (at 9867) by debbugs.gnu.org; 20 Aug 2019 08:19:47 +0000 Original-Received: from localhost ([127.0.0.1]:60860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzzMp-0006Eo-Dv for submit@debbugs.gnu.org; Tue, 20 Aug 2019 04:19:47 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:36377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzzMm-0006Eb-LI for 9867@debbugs.gnu.org; Tue, 20 Aug 2019 04:19:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566289172; bh=ZWz9EU5iUi+ZevDkW5czZ532+F05MLIimb5YDPvbzEA=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Ca0uA8Xq2ev7CfM4h4X5E9NCfRR69AcOmiFixacPIFzIdBqYHdupjSuJ4+W/q+iOY zgoX+Bgfn/OFppXRDUGJXFydYBAC+TbCeYhyK8Bs6g9YX5nU6cqE9r/jW7lY0+FpQp 9sPqxj1mOczi2NRWnsz49C8SI8EvkozCScPC3HmU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([212.95.5.135]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MAwXh-1i6Gle398j-00BINb; Tue, 20 Aug 2019 10:19:31 +0200 In-Reply-To: <87d0h01sqf.fsf@mouse.gnus.org> Content-Language: de-DE X-Provags-ID: V03:K1:TkpDYn7osu/tqhQOrlNPB6yN6/rU1EY5MvXBpP4lUN9jyWBBQZS 38VVvHta+D4CmvRmxw9K3PTz7cVLJVoFS0jiSP7HofzK6kkvo/a4NGM4QJsGUSIcvqdLowr aZJwGP6ZsXcW52CWsQof3MyebtfhdIEYP/B6q4YFYl6BN1eG+5Iw7SqGrrj7I2i1sjaPAnS LN2jAF2mX1tXR18nJX2IA== X-UI-Out-Filterresults: notjunk:1;V03:K0:CAo8+IwIlH4=:hzl7+p2lBYPq/fwVqe/3La ASpS8WDyD65BfS4oz2wLmH58qFFdGLmGsPkmmEBFspe3XH2aF0fYS0dxR/2LlHc4pvInAT613 I0o8O6KYGzDqqXa2LYYafL6BAA/m/Su7GY0yNoqr4tX5TB/KDO98Ct6BDysVKSKjYU9q9Y7qT 0ieNcWavwcaPpTJfoDOIvrH/VGTK1fP0rDFlXfXsBSm/KAoIazPP0FtpZo6EuqRo1APCMoabO 3mzb4lmhYxkx/H+6cf+N7B+sgOFQBd39oEbdslh513lxHv+Kq9E7udZ3Lze1w1aud6p5LpEk6 EwUjfcyOdZOuEQcbQN4GxKQvfSEvCFGBlSWRD8ztq9SKZ1xzW6kApO3scAP6zZkG+Bs6+r55G StAcqiaMQ0CXe+8mn5Slo/5JTBd6SO66KTapxCuqq5EpKvyhhzoWlPmcMFazL0mihSanhwWhB gNcUxidaoOzeT6BBqT5QTB0OshvOoxlfd/2vpgIySCINj/oID2QnvRfQpBUbZlVFp8GXYwYBo rTHXH0WRmfeY1sB3WEd7NIMjr3gk4b7E61GBcOz40H1y8cHChZb/7sYQb3vavfGXbAw+sUBCI ORyjdFBPL1RyKI+rPpBjUFWxp5+Qs43g/qq2QBgvnO0wdzWhHt7/GCJ1Ql9yYDEjCgcOX5NrI szltmYXFhfI2aKrvgVhmzToE8SgrKjAxeVpOSuGrpEvD7BKe8nNSs8H3w3R7TqGqj92csg+OC QhXCbzxX9VXbjSMRlo9+we5IoM2AvghXiQ9hEJvn6uSvq2ebKktmTaKSeyeN1lXXMNZxwDYC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165402 Archived-At: > It seems like Chong OK'd this hook at the time, but it was never added > to Emacs. I've now added it to Emacs 27, because it seems like a useful > addition to have -- now modes that need to do some clean-up thing before > doing whatever `quit-window' does can just add that to the hook > (buffer-locally). 'quit-restore-window' can quit _any_ window not just the selected one. This means that if a user puts something on a normal hook run by that function, that something can only guess at which window is really quit by that function. Also, running a buffer-local value of that hook is meaningless given the current implementation. See the tribulations run_window_configuration_change_hook runs into when trying to overcome a similar problem (and note the unwind-protection overhead it incurs). If people really need such a hook at all, please - Make it either an abnormal hook run with the window quit as argument or run it from 'quit-window' but then only if it quits the selected window. - Make sure to call any buffer-local value of that hook for the buffer of the window that is quit. - Prefix it with 'quit-restore-' if you intend to run it from 'quit-restore-window' (that function may be called by other functions as well). - Fix the reference to the non-existent function 'quit-buffer'. Thanks, martin