From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#12314: 24.2.50; `add-to-history': use `setq' with `delete' Date: Thu, 30 Aug 2012 16:08:05 -0700 Message-ID: <7602D24B74DE42CF9901322634B85CA2@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1346368142 27423 80.91.229.3 (30 Aug 2012 23:09:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 Aug 2012 23:09:02 +0000 (UTC) To: 12314@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 31 01:09:03 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T7Dr5-0001Ik-VS for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Aug 2012 01:08:56 +0200 Original-Received: from localhost ([::1]:44967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7Dr3-0006PG-9j for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Aug 2012 19:08:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7Dr0-0006PA-Tx for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2012 19:08:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7Dqz-0005fC-Up for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2012 19:08:50 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7Dqz-0005f8-RP for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2012 19:08:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T7Ds9-0006DX-Oh for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2012 19:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Aug 2012 23:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12314 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.134636816823851 (code B ref -1); Thu, 30 Aug 2012 23:10:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Aug 2012 23:09:28 +0000 Original-Received: from localhost ([127.0.0.1]:58597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T7Drb-0006Cd-3k for submit@debbugs.gnu.org; Thu, 30 Aug 2012 19:09:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51239) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T7DrY-0006CW-Ms for submit@debbugs.gnu.org; Thu, 30 Aug 2012 19:09:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7DqN-0005bJ-FH for submit@debbugs.gnu.org; Thu, 30 Aug 2012 19:08:12 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:54542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7DqN-0005bD-Bi for submit@debbugs.gnu.org; Thu, 30 Aug 2012 19:08:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7DqM-0006Ok-HD for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2012 19:08:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7DqL-0005ay-JF for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2012 19:08:10 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:49438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7DqL-0005ar-C4 for bug-gnu-emacs@gnu.org; Thu, 30 Aug 2012 19:08:09 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q7UN87eL009281 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 30 Aug 2012 23:08:08 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q7UN86oK004885 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 30 Aug 2012 23:08:07 GMT Original-Received: from abhmt109.oracle.com (abhmt109.oracle.com [141.146.116.61]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q7UN86EN024664 for ; Thu, 30 Aug 2012 18:08:06 -0500 Original-Received: from dradamslap1 (/130.35.178.248) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 30 Aug 2012 16:08:06 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac2HBE+yu4ZaRfw2SJmh1u1ByGJILw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63617 Archived-At: This line in `add-to-history': (if history-delete-duplicates (delete newelt history)) should be this: (if history-delete-duplicates (setq history (delete newelt history))) (Or for more clarity, use `when' instead of `if'.) I'm not 100% sure this is a problem, but it seems to be in a case I saw. And there seems to be no reason not to set `history' to the `delete' result here. In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600) of 2012-08-26 on MARVIN Bzr revision: 109788 dmantipov@yandex.ru-20120827041533-3cy7pdjdqz14o90c Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'