From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#12299: 24.1; no byte compiler warning for inline function call with too few arguments [PATCH] Date: Fri, 23 Jul 2021 15:18:28 +0200 Message-ID: <75945564-080D-4EC6-BD3E-2A70C72BE492@acm.org> References: <743DF3D0-DA0F-49D4-A780-02C698AE8EFB@acm.org> <878s1xffr9.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30044"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 12299@debbugs.gnu.org, Stefan Monnier , Roland Winkler To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 23 15:19:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6v53-0007fk-Lw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jul 2021 15:19:09 +0200 Original-Received: from localhost ([::1]:44108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6v52-0008Na-NB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jul 2021 09:19:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6v4w-0008L9-3j for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 09:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6v4v-0000Km-RF for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 09:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6v4v-0004kZ-OV for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 09:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jul 2021 13:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12299 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 12299-submit@debbugs.gnu.org id=B12299.162704631818222 (code B ref 12299); Fri, 23 Jul 2021 13:19:01 +0000 Original-Received: (at 12299) by debbugs.gnu.org; 23 Jul 2021 13:18:38 +0000 Original-Received: from localhost ([127.0.0.1]:42595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6v4Y-0004jq-Bt for submit@debbugs.gnu.org; Fri, 23 Jul 2021 09:18:38 -0400 Original-Received: from mail74c50.megamailservers.eu ([91.136.10.84]:43158 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6v4U-0004jb-BK for 12299@debbugs.gnu.org; Fri, 23 Jul 2021 09:18:37 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627046312; bh=Gcm7yvjTL7/sNEyFwNVGTgQ2ftJAhh4I0H4B73w+ryU=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Af7696lJlxLXS3pa9SmcSEWIxJBHhC5hwCaR8dpxTqvim771bFvOzYJTImWmYHSx1 B1dFRrFfe4ax1nd6eWr0mRKLNzHrpHu/zodIaJwFJZJ/WnYtSOI/LzxoC8mYJ0lAQL Wpv1AqICFdzoLYzAp/ZXkmTwdIGDZkHOOlhZ8nBo= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16NDITs7005424; Fri, 23 Jul 2021 13:18:30 +0000 In-Reply-To: <878s1xffr9.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1D.60FAC1A8.003C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=UJ+j4xXy c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=Ve99FEDGdn45tTQE:21 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=IsmX_BOBuKVwxy18mnoA:9 a=QEXdDO2ut3YA:10 a=RW9lQ-4mb-ULxO3qII2u:22 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210583 Archived-At: 23 juli 2021 kl. 13.09 skrev Lars Ingebrigtsen : > Yes, we can fix up suppression afterwards... It's not a new problem -- there are plenty of warnings that can be = generated during the source-level optimisation and suppressions don't = work there right now. > This leads to warnings like: >=20 > Warning: Eager macro-expansion skipped due to cycle: > =E2=80=A6 =3D> (load "byte-opt.el") =3D> (macroexpand-all (defalias = 'byte-decompile-bytecode-1 =E2=80=A6)) =3D> (macroexpand = (cl-symbol-macrolet =E2=80=A6)) =3D> (load "byte-opt.el") Strange. I never saw anything like that. But if bootstrapping helped = you, then I suppose it's fine. > I wondered whether this added warning would find errors in the Emacs > tree, so I did a "make bootstrap" after applying the patch, but we > apparently have none of those, which surprised me. Yes, I'm disappointed as well. Had hoped for some juicy pay-off, but no. Thanks for testing it -- pushed to master, slightly simplified (somehow = I completely missed the existence of `func-arity`)